Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete button in FS view #552

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Delete button in FS view #552

merged 2 commits into from
Mar 11, 2024

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Mar 10, 2024 •
edited
Loading

fs-delete

@iBicha iBicha marked this pull request as ready for review March 10, 2024 21:50
@iBicha iBicha changed the title [WIP] delete button in FS view Delete button in FS view Mar 10, 2024
@iBicha
Copy link
Contributor Author

iBicha commented Mar 10, 2024

A weird thing is that files under common: return permissions rw. So the delete button is there but won't work because we don't have permissions to delete the files. Perhaps this kind of filtering should be based on the returned permissions + hardcoded exceptions (like common:). But it's also a very minor thing, I don't think anyone would be confused why common: files are not being deleted.

@TwitchBronBron TwitchBronBron merged commit 2454ace into rokucommunity:master Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triwav triwav triwav approved these changes

@chrisdp chrisdp Awaiting requested review from chrisdp

@TwitchBronBron TwitchBronBron Awaiting requested review from TwitchBronBron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iBicha @triwav @TwitchBronBron @chrisdp