Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on device brightscript repl #564

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Add on device brightscript repl #564

merged 5 commits into from
Apr 24, 2024

Conversation

triwav
Copy link
Collaborator

@triwav triwav commented Apr 24, 2024 •
edited
Loading

Apr-24-2024 11-24-20

@triwav triwav marked this pull request as ready for review April 24, 2024 13:01
TwitchBronBron
TwitchBronBron approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! We spoke about a few suggestions, but up to you if you want to implement them.

@triwav triwav merged commit e9df0c0 into master Apr 24, 2024
5 checks passed
@triwav triwav deleted the on_device_brightscript_repl branch April 24, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triwav @TwitchBronBron