-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v2.5.6+506 #131
Open
mihail-varbanov
wants to merge
27
commits into
master
Choose a base branch
from
release/v2.5.6+506
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/v2.5.6+506 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with _determineIsOpen not checking weekDay Part of the code that displays the next open time called _determineIsOpen with an arbitrary period. However, that function assumed it would only be called with a period for the current day. Refactor the methods a bit and add a check for the weekDay. * Keep number of minutes in HealthLocationDayOfOperation instead of TimeOfDay, added some null pointer checks. * Added a null pointer check for current period in TestLocationsPanel. Co-authored-by: Mihail Varbanov <[email protected]>
Bug introduced by adding props to the instance instead of using utility functions. Before, the utility function would catch the null case. Now, that needs to be caught before checking the prop.
…instead that actually contain the same status rules.
Feature/issue 125
…id19StatusBlob (#128).
Feature/issue 128
Feature/issue 127
* master: (46 commits) Update CHANGELOG.md Update pubspec.yaml Update pubspec.yaml Revert "Release/v2.5.2+402" Update CHANGELOG.md Version: 2.5.2+402 Updated changelog. Feature/issue 108 (#114) Feature/issue 113 (#116) Updated changelog. Fix issue with _determineIsOpen not checking weekDay (#111) Updated changelog. Mark pending event that persist in history table as processed. Updated changelog. Do not process pending events if we failed to load history (#94). Updated Health rules (#107). Feature/issue 100 2.5 (#105) Dont add/process OSF test if it's not enetered as test type within the system Android: prevent screenshots [Issue # 97] (#101) Feature/issue 87 2.5 (#89) ... # Conflicts: # pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sandeep-ps, this is v2.5.6 release candidate from yesterday (Tue, Sep 8). @pmarkhennessy wanted me to create a PR for it. Most probably today there will be a new 2.5.7 release candidate and another PR for it.