Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v2.5.6+506 #131

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Release/v2.5.6+506 #131

wants to merge 27 commits into from

Conversation

mihail-varbanov
Copy link
Collaborator

Hi @sandeep-ps, this is v2.5.6 release candidate from yesterday (Tue, Sep 8). @pmarkhennessy wanted me to create a PR for it. Most probably today there will be a new 2.5.7 release candidate and another PR for it.

Mihail Varbanov and others added 27 commits September 2, 2020 12:52
* Fix issue with _determineIsOpen not checking weekDay

Part of the code that displays the next open time called
_determineIsOpen with an arbitrary period. However, that function
assumed it would only be called with a period for the current day.
Refactor the methods a bit and add a check for the weekDay.

* Keep number of minutes in HealthLocationDayOfOperation instead of TimeOfDay, added some null pointer checks.

* Added a null pointer check for current period in TestLocationsPanel.

Co-authored-by: Mihail Varbanov <[email protected]>
Bug introduced by adding props to the instance instead of using
utility functions. Before, the utility function would catch the
null case. Now, that needs to be caught before checking the prop.
…instead that actually contain the same status rules.
* master: (46 commits)
  Update CHANGELOG.md
  Update pubspec.yaml
  Update pubspec.yaml
  Revert "Release/v2.5.2+402"
  Update CHANGELOG.md
  Version: 2.5.2+402
  Updated changelog.
  Feature/issue 108 (#114)
  Feature/issue 113 (#116)
  Updated changelog.
  Fix issue with _determineIsOpen not checking weekDay (#111)
  Updated changelog.
  Mark pending event that persist in history table as processed.
  Updated changelog.
  Do not process pending events if we failed to load history (#94).
  Updated Health rules (#107).
  Feature/issue 100 2.5 (#105)
  Dont add/process OSF test if it's not enetered as test type within the system
  Android: prevent screenshots [Issue # 97] (#101)
  Feature/issue 87 2.5 (#89)
  ...

# Conflicts:
#	pubspec.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants