chore: set platform option and remove workaround in environment-react…

…-ssr playground
rolldown · Nov 29, 2024 · 68e6581 · 68e6581
1 parent 7c8a9ee
commit 68e6581
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -419,6 +419,9 @@ export function resolveBuildEnvironmentOptions(
       ...buildEnvironmentOptionsDefaults,
       cssCodeSplit: !raw.lib,
       minify: consumer === 'server' ? false : 'esbuild',
+      rollupOptions: {
+        platform: consumer === 'server' ? 'node' : 'browser',
+      },
       ssr: consumer === 'server',
       emitAssets: consumer === 'client',
       createEnvironment: (name, config) => new BuildEnvironment(name, config),

diff --git a/playground/environment-react-ssr/vite.config.ts b/playground/environment-react-ssr/vite.config.ts
@@ -47,11 +47,6 @@ export default defineConfig((env) => ({
           input: {
             index: '/src/entry-server',
           },
-          output: {
-            // NOTE: needed for now: https://github.com/rolldown/rolldown/issues/2685
-            banner:
-              "import { createRequire as ___createRequire } from 'module'; const require = ___createRequire(import.meta.url);",
-          },
         },
       },
     },