fix: externalize optimizeDeps.exclude
via rolldownCjsExternalPlugin
(fix test-serve playground/external
)
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
optimizeDeps.exclude
is externalized at the config levelrolldown.rolldown({ external: ... })
and it looks likerolldownCjsExternalPlugin
doesn't have a chance to fixup cjs external. This manifests as test failures inplayground/external
.Since
rolldownCjsExternalPlugin
also handles non-cjs external, I simply removed rolldown'sexternal
config and it looks like tests are passing.Only the last commit 5edc81d is the actual fix and first commits are the same one from #28.