Skip to content

Commit

Permalink
Merge pull request #86 from SpaNb4/react-redux
Browse files Browse the repository at this point in the history
update react-redux
  • Loading branch information
kravaring authored Jul 28, 2024
2 parents ec915f5 + 399178a commit 3926073
Showing 1 changed file with 19 additions and 24 deletions.
43 changes: 19 additions & 24 deletions active-tasks/react_redux.json
Original file line number Diff line number Diff line change
@@ -1,51 +1,46 @@
{
"taskName": "React Redux",
"github": "https://github.com/rolling-scopes-school/tasks/tree/master/react/modules/module04",
"information": "The maximum number of points is 15. Those are the cross-code-review and cross-check criterias:",
"github": "https://github.com/rolling-scopes-school/tasks/blob/master/react/modules/tasks/redux.md",
"information": "The maximum number of points is 200. Those are the cross-code-review and cross-check criterias:",
"criteria": [
{
"type": "title",
"title": "Cross code review"
},
{
"type": "subtask",
"text": "Redux is integrated into the app with the help of Redux Toolkit",
"max": 25
"text": "RTK query is used for api calls",
"max": 50
},
{
"type": "subtask",
"text": "Search is saved in the store",
"max": 5
"text": "Selected items are managed through the redux store, selected items are persistent across pages",
"max": 50
},
{
"type": "subtask",
"text": "Items per page is saved in the store",
"max": 5
},
{
"type": "subtask",
"text": "View mode is saved in the store",
"max": 10
"text": "Flyout component is showed/hidden based on the presence of selected items, displays the number of selected items",
"max": 20
},
{
"type": "subtask",
"text": "Loading indicators are shown, loading flags are saved in the store",
"max": 10
"text": "\"Unselect all\" button and \"Download\" button work according to the requirements",
"max": 35
},
{
"type": "subtask",
"text": "When either search or items per page is changed, the application makes a new call using RTK Query to fetch the data",
"max": 25
"text": "User can switch the theme of the application",
"max": 45
},
{
"type": "subtask",
"text": "Tests had been modified to test the functionality using Redux and RTK Query",
"max": 20
"type": "penalty",
"text": "TypeScript isn't used",
"max": -195
},
{
"type": "penalty",
"text": "TypeScript isn't used",
"max": -95
"text": "Test coverage below 80%",
"max": -100
},
{
"type": "penalty",
Expand Down Expand Up @@ -79,8 +74,8 @@
},
{
"type": "penalty",
"text": "Test coverage is less than 80%",
"max": -30
"text": "Pull Request doesn't follow guideline (including checkboxes in Score)",
"max": -10
}
]
}

0 comments on commit 3926073

Please sign in to comment.