Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code S1E1 #103

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+167 −118
Open

Clean Code S1E1 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d71a0b9
init: adding files for clean-code-s1e1 task
Alexandr-Kolos Dec 10, 2024
1c3fb64
fix(basic-1.1): add two spaces in HTML and CSS
Alexandr-Kolos Dec 11, 2024
1a637c1
fix(basic-1.1): add two spaces in CSS
Alexandr-Kolos Dec 11, 2024
1c9dbfd
fix(basic-1.2): use lowercase for HTML and CSS
Alexandr-Kolos Dec 11, 2024
6dc2879
fix(basic-1.3): add double qoutes for HTML and CSS
Alexandr-Kolos Dec 11, 2024
a73f0c2
fix(basic-2.1): formatting HTML file
Alexandr-Kolos Dec 15, 2024
c1f1e18
fix(basic-2.2): add Html5 DOCTYPE tag
Alexandr-Kolos Dec 15, 2024
dae613a
fix(basic-2.3): remove character references
Alexandr-Kolos Dec 15, 2024
face138
fix(basic-2.4): delete type attribute
Alexandr-Kolos Dec 15, 2024
dcdf1e2
fix(basic-2.5): add HTML Line-Wrapping
Alexandr-Kolos Dec 15, 2024
e7bcaff
fix(basic-3.1): change names classes
Alexandr-Kolos Dec 16, 2024
485ee42
fix(basic-3.6): space property
Alexandr-Kolos Dec 16, 2024
4e0bd97
fix(basic-3.7): Semicolon after properties
Alexandr-Kolos Dec 16, 2024
318461e
fix(basic-3.8): Separate selectors
Alexandr-Kolos Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 76 additions & 17 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,78 @@
<!DOCTYPE html>
<html>
<HEAD><title>Todo App</title>
<link href='https://fonts.googleapis.com/css?family=Lato:300,400,700' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="style.css" type="text/css" MEDIA="screen" charset="utf-8">
</HEAD>
<body>
<div class="aaa"><img src="./eisenhower-matrix.jpg"><a class='more_inf' href="https://goal-life.com/page/method/matrix-eisenhower">Want more details&quest;</a></div>
<div class="centered-main-page-element"><p id='topSectionForAddingElementToList'><label for="new-task">Add Item</label><div class="task-row-wrapper"><input id='new-task'class="task" type="text"><button>Add</button></div>
</p><h3>Todo</h3>
<ul id='incompleteTasks'>
<li><input type='checkbox'><label class="task">Pay Bills</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button></li>
<li class="editMode"><input type="checkbox"><label class="task">Go Shopping</label><input type="text" value="Go Shopping" class="task"><button class='edit'>Save</button><button class="delete"><img src="./remove.svg"></button></li>
</ul><h3>Completed</h3><ul id="completed-tasks"><li><input type="checkbox" checked><label class="task">See the Doctor</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button>
</li>
</ul>
</div>
<script type="text/javascript" SRC="app.js"></script>
</body>
<head>
<title>Todo App</title>
<link
href="https://fonts.googleapis.com/css?family=Lato:300,400,700"
rel="stylesheet"
>
<link
rel="stylesheet"
href="style.css"
media="screen"
charset="utf-8"
>
</head>
<body>
<div class="header">
<img class="header__image" src="./eisenhower-matrix.jpg">
<a
class="header__more-inf"
href="https://goal-life.com/page/method/matrix-eisenhower"
>
Want more details?
</a>
</div>
<div class="main-page__content">
<p class="content__task-section">
<label for="new-task">Add Item</label>
<div class="task-section__wrapper">
<input
id="new-task"
class="task-section__input"
type="text"
>
<button>Add</button>
</div>
</p>
<h3>Todo</h3>
<ul id="incompleteTasks">
<li>
<input type="checkbox">
<label class="task">Pay Bills</label>
<input type="text" class="task">
<button class="edit">Edit</button>
<button class="delete">
<img src="./remove.svg">
</button>
</li>
<li class="editMode">
<input type="checkbox">
<label class="task">Go Shopping</label>
<input
type="text"
value="Go Shopping"
class="task"
>
<button class="edit">Save</button>
<button class="delete">
<img src="./remove.svg">
</button>
</li>
</ul>
<h3>Completed</h3>
<ul id="completed-tasks">
<li>
<input type="checkbox" checked>
<label class="task">See the Doctor</label>
<input type="text" class="task">
<button class="edit">Edit</button>
<button class="delete">
<img src="./remove.svg">
</button>
</li>
</ul>
</div>
<script src="app.js"></script>
</body>
</html>
192 changes: 91 additions & 101 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,148 +1,138 @@
/* Basic Style */
body {
background-color: #f8f8f8;
color: #333;
font-family: Lato, sans-serif;
background-color: #f8f8f8;
color: #333;
font-family: Lato, sans-serif;
}
.aaa {
width: 500px;
margin: 0 auto;
display: block;
text-align: right;
.header {
width: 500px;
margin: 0 auto;
display: block;
text-align: right;
}
.aaa img {
width: 100%;
.header__image {
width: 100%;
}
.aaa .more_inf {
font-family: fantasy, cursive;
.header__more-inf {
font-family: fantasy, cursive;
}

@media (max-width:768px) {
.aaa { text-align: center;
}
.header {
text-align: center;
}
}
.centered-main-page-element {
display: block;
width: 500px;
margin: 0 auto 0;
.main-page__content {
display: block;
width: 500px;
margin: 0 auto 0;
}
.task {
width: 56%;
display: inline-block;
flex-grow: 1
.task-section__input {
width: 56%;
display: inline-block;
flex-grow: 1;
}
.task-row-wrapper {
display: flex;
.task-section__wrapper {
display: flex;
}
ul {
margin:0;
padding: 0px;
.content__list {
margin: 0;
padding: 0px;
}
li, h3 {
list-style:none;
li,
h3 {
list-style: none;
}
input,button{
outline:none;
input,
button {
outline: none;
}
button {
background: none;
border: 0px;
color: #888;
font-size: 15px;
width: 60px;
font-family: Lato, sans-serif;
cursor: pointer;
background: none;
border: 0px;
color: #888;
font-size: 15px;
width: 60px;
font-family: Lato, sans-serif;
cursor: pointer;
}
button:hover {
color: #3a3A3a;
color: #3a3a3a;
}
/* Heading */
h3,
label[for='new-task'] {
color: #333;
font-weight: 700;
font-size: 15px;
border-bottom: 2px solid #333;
padding: 30px 0 10px;
margin: 0;
text-transform: uppercase;
label[for="new-task"] {
color: #333;
font-weight: 700;
font-size: 15px;
border-bottom: 2px solid #333;
padding: 30px 0 10px;
margin: 0;
text-transform: uppercase;
}
input[type="text"] {
margin: 0;
font-size: 18px;
line-height: 18px;
height: 21px;
padding: 0 9px;
border: 1px solid #dDd;
background: #FFF;
border-radius: 6px;
font-family: Lato, sans-serif;
color: #888;
margin: 0;
font-size: 18px;
line-height: 18px;
height: 21px;
padding: 0 9px;
border: 1px solid #ddd;
background: #fff;
border-radius: 6px;
font-family: Lato, sans-serif;
color: #888;
}
input[type="text"]:focus {
color: #333;
color: #333;
}

/* New Task */
label[for='new-task'] {
display: block;
margin: 0 0 20px;
label[for="new-task"] {
display: block;
margin: 0 0 20px;
}
input#new-task {
width: 318px;
width: 318px;
}

/* Task list */
li {
overflow: hidden;
padding: 20px 0;
border-bottom: 1px solid #eee;
overflow: hidden;
padding: 20px 0;
border-bottom: 1px solid #eee;

display: flex;
justify-content: space-between;
align-items: center;
display: flex;
justify-content: space-between;
align-items: center;
}
li > * {
vertical-align: middle;
vertical-align: middle;
}

li > input[type="checkbox"] {
margin: 0 10px;
margin: 0 10px;
}
li > label {
padding-left: 10px;
box-sizing: border-box;
font-size: 18px;
width: 226px;
padding-left: 10px;
box-sizing: border-box;
font-size: 18px;
width: 226px;
}
li > input[type="text"] {
width: 226px
li > input[type="text"] {
width: 226px
}
button.delete img {
height: 2em;
transform: rotateZ(45deg);
transition: transform 200ms ease-in;
height: 2em;
transform: rotateZ(45deg);
transition: transform 200ms ease-in;
}
button.delete img:hover {
transform: rotateZ(0);
transform: rotateZ(0);
}

/* Completed */
ul#completed-tasks label {
text-decoration: line-through
color: #888;
text-decoration: line-through;
color: #888;
}

/* Edit Task */
ul li input[type=text] {
display:none
ul li input[type="text"] {
display: none;
}

ul li.editMode input[type=text] {
display:inline-block;
width:224px
ul li.editMode input[type="text"] {
display:inline-block;
width: 224px;
}

ul li.editMode label {
display:none;
display: none;
}