Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code s1e1 #44

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Dasha2101
Copy link

@Dasha2101 Dasha2101 commented Jan 8, 2024

(Проверяющим)
Добрый день! Я случайно засбмитила первый пул реквест из репозитория школы. Не могли бы вы проверить, данную ссылку (пул реквест из моего аккаунта. так как я не могу пересабмитить ссылку уже, была бы вам очень благодарна!
My privite pull request - link: Dasha2101#2

1.Task: https://github.com/rolling-scopes-school/tasks/blob/master/stage1/modules/clean-code/clean-code-s1e1.md
2. Screenshon:
image
3. Deploy: https://dasha2101.github.io/clean-code-s1e1/
4. Done 09.01.2024 / deadline 09.01.2024
Score: 45 / 45
Basic level +30:
1.1. Indentation +2;
1.2. Use lowercase +2;
1.3. Quotes in HTML & CSS files +2;
2.1. Formatting +2;
2.2. Document Type +2;
2.3. Named character references +2;
2.4. 'type' attribute +2;
3.1. Single style for selectors naming +2;
3.2. Meaningful naming of identifiers and classes +2;
3.3. Keep the names of identifiers and classes concise +2;
3.4. Tag selectors +2;
3.5. Indentation in blocks +2;
3.6. Space after property name +2;
3.7. Semicolon after properties +2;
3.8. Separate selectors and properties +2.
Advanced level +15:
1.1. Semantics +5;
1.2. Media alternatives +5;
2.1. update CSS according to BEM +5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant