Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ Add DonationV1 DonationV2 Community Speakers #28

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Feature/ Add DonationV1 DonationV2 Community Speakers #28

merged 7 commits into from
Oct 27, 2022

Conversation

aleksKudr
Copy link
Collaborator

@aleksKudr aleksKudr commented Oct 24, 2022 •
edited
Loading

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

Implement "Donation / v1" block
Implement "Donation / v2" block
Implement "Community description / v1" block
Implement "Speakers wanted / v1" block

💡 Background and solution

Describe the big picture of your changes here

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@vercel
Copy link

vercel bot commented Oct 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rs-site ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 9:41AM (UTC)

@aleksKudr aleksKudr changed the base branch from main to develop October 24, 2022 21:34
crzoukman
crzoukman reviewed Oct 26, 2022
View reviewed changes
components/DonationV2/donationV2.tsx Outdated Show resolved Hide resolved
components/DonationV2/donationV2.tsx Outdated Show resolved Hide resolved
components/DonationV1/index.ts Outdated Show resolved Hide resolved
components/DonationV2/donationV2.tsx Outdated Show resolved Hide resolved
@crzoukman crzoukman self-requested a review October 26, 2022 06:36
@oleksiisydorenko1 oleksiisydorenko1 added this to the 0.0.1 milestone Oct 26, 2022
@aleksKudr aleksKudr changed the title Feature/issue 11 Feature/issue-11-issue-14-issue-12-issue-10 Oct 26, 2022
@vercel vercel bot temporarily deployed to Preview October 26, 2022 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview October 26, 2022 20:20 Inactive
@aleksKudr aleksKudr changed the title Feature/issue-11-issue-14-issue-12-issue-10 Feature/ Add DonationV1 DonationV2 Community Speakers Oct 26, 2022
@oleksiisydorenko1
Copy link
Collaborator

@aleksKudr build не прошёл, попробуй запустить локально и посмотреть ошибку

@aleksKudr
Copy link
Collaborator Author

@aleksKudr build не прошёл, попробуй запустить локально и посмотреть ошибку

Локально build без ошибок

@vercel vercel bot temporarily deployed to Preview October 27, 2022 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 09:41 Inactive
This was referenced Oct 27, 2022
Closed
Closed
@aleksKudr aleksKudr merged commit e0434ed into develop Oct 27, 2022
@M0rtari0n M0rtari0n mentioned this pull request Oct 27, 2022
Closed
SyleimanovSergey
SyleimanovSergey reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@SyleimanovSergey SyleimanovSergey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

@alexey-koran alexey-koran deleted the feature/issue-11 branch March 18, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyleimanovSergey SyleimanovSergey SyleimanovSergey left review comments

@oleksiisydorenko1 oleksiisydorenko1 oleksiisydorenko1 approved these changes

@crzoukman crzoukman crzoukman approved these changes

Assignees
No one assigned
Labels
deploy
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksKudr @oleksiisydorenko1 @SyleimanovSergey @crzoukman