fix: Do not apply cross-check score more than max score of a task (#2540

) * chore: Do not apply cross-check score more than max score of a task * Excplicit error message for score exceeding max score * Add check from front-end side for score exceeding max score * Update client/src/pages/course/student/cross-check-review.tsx Co-authored-by: Valery <[email protected]> * Update client/src/pages/course/student/cross-check-review.tsx Co-authored-by: Valery <[email protected]> --------- Co-authored-by: Valery <[email protected]>
rolling-scopes · Oct 16, 2024 · 758a203 · 758a203
1 parent 2577812
commit 758a203
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/client/src/pages/course/student/cross-check-review.tsx b/client/src/pages/course/student/cross-check-review.tsx
@@ -140,6 +140,10 @@ function Page() {
 
   const submitReview = withLoading(async values => {
     try {
+      if (values.maxScore != null && values.maxScore < score) {
+        message.error(`The score (${score}) exceeds the maximum score (${values.maxScore}) for the task.`);
+        return;
+      }
       await courseService.postTaskSolutionResult(values.githubId, values.courseTaskId, {
         score,
         comment: markdownLabel + values.comment,

diff --git a/server/src/routes/course/crossCheck/createResult.ts b/server/src/routes/course/crossCheck/createResult.ts
@@ -62,6 +62,11 @@ export const createResult = (_: ILogger) => async (ctx: Router.RouterContext) =>
     review: Array.isArray(inputData.review) ? inputData.review : [],
   };
 
+  if (data.score > courseTask.maxScore) {
+    setErrorResponse(ctx, BAD_REQUEST, 'score provided is greater than max score for the task');
+    return;
+  }
+
   if (isNaN(data.score) || data.score < 0) {
     setErrorResponse(ctx, BAD_REQUEST, 'no score provided');
     return;