Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cross-Check distribute only active students #2251

Conversation

ThorsAngerVaNeT
Copy link
Contributor

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

#2138

πŸ’‘ Background and solution

Describe the big picture of your changes here

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@ThorsAngerVaNeT ThorsAngerVaNeT changed the title Feature: Cross-Check ditribute only active students Feature: Cross-Check distribute only active students Aug 7, 2023
@valerydluski
Copy link
Contributor

Is this pull request needed?

@ThorsAngerVaNeT
Copy link
Contributor Author

ThorsAngerVaNeT commented Aug 7, 2023

Is this pull request needed?

There are two separate functionalities. So I believe - yes
JFYI: You provide a link to a different PR and there is no connection between them

@ThorsAngerVaNeT ThorsAngerVaNeT force-pushed the feat/xcheck-ditribute-only-active-students branch from 14fc42c to 9c59dcc Compare August 7, 2023 18:50
Copy link
Member

@apalchys apalchys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@apalchys apalchys merged commit 72d49e8 into rolling-scopes:master Aug 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants