Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cross-check api #2256

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: update cross-check api #2256

merged 1 commit into from
Aug 8, 2023

Conversation

valerydluski
Copy link
Contributor

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

Describe the source of requirement, like related issue link.

💡 Background and solution

Describe the big picture of your changes here

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

📦 Next.js Bundle Analysis for client

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 290.1 KB 438.8 KB 87.76% (+/- <0.01%)
/404 202.05 KB 350.75 KB 70.15% (+/- <0.01%)
/admin/courses 369.71 KB 518.41 KB 103.68% (+/- <0.01%)
/admin/disciplines 309.74 KB 458.44 KB 91.69% (+/- <0.01%)
/admin/discord-server 342.32 KB 491.01 KB 98.20% (+/- <0.01%)
/admin/events 342.9 KB 491.59 KB 98.32% (+/- <0.01%)
/admin/mentor-registry 366.93 KB 515.63 KB 103.13% (+/- <0.01%)
/admin/notifications 376.54 KB 525.24 KB 105.05% (+/- <0.01%)
/admin/registrations 320.73 KB 469.42 KB 93.88% (🟡 +0.01%)
/admin/tasks 406.2 KB 554.9 KB 110.98% (+/- <0.01%)
/admin/user-group 343.89 KB 492.59 KB 98.52% (+/- <0.01%)
/admin/users 258.45 KB 407.14 KB 81.43% (+/- <0.01%)
/applicants 312.76 KB 461.46 KB 92.29% (+/- <0.01%)
/course/admin/cross-check-table 379.05 KB 527.75 KB 105.55% (+/- <0.01%)
/course/admin/events 401.45 KB 550.15 KB 110.03% (+/- <0.01%)
/course/admin/interviews 345.59 KB 494.28 KB 98.86% (+/- <0.01%)
/course/admin/mentors 351.27 KB 499.97 KB 99.99% (+/- <0.01%)
/course/admin/stage-interviews 347.19 KB 495.89 KB 99.18% (+/- <0.01%)
/course/admin/students 358.15 KB 506.85 KB 101.37% (+/- <0.01%)
/course/admin/tasks 377.34 KB 526.04 KB 105.21% (+/- <0.01%)
/course/admin/users 345.33 KB 494.03 KB 98.81% (+/- <0.01%)
/course/interview/[type]/feedback 281.09 KB 429.79 KB 85.96% (+/- <0.01%)
/course/mentor/auto-confirm 222.78 KB 371.48 KB 74.30% (+/- <0.01%)
/course/mentor/confirm 263.33 KB 412.03 KB 82.41% (+/- <0.01%)
/course/mentor/dashboard 388.99 KB 537.69 KB 107.54% (+/- <0.01%)
/course/mentor/expel-student 271.27 KB 419.96 KB 83.99% (+/- <0.01%)
/course/mentor/feedback 257.93 KB 406.63 KB 81.33% (+/- <0.01%)
/course/mentor/interview-technical-screening 261.43 KB 410.13 KB 82.03% (+/- <0.01%)
/course/mentor/interview-wait-list 323.58 KB 472.27 KB 94.45% (+/- <0.01%)
/course/mentor/interviews 315.23 KB 463.92 KB 92.78% (🟡 +0.01%)
/course/mentor/students 228.78 KB 377.47 KB 75.49% (🟡 +0.01%)
/course/schedule 428.4 KB 577.1 KB 115.42% (+/- <0.01%)
/course/score 335.47 KB 484.17 KB 96.83% (+/- <0.01%)
/course/student/auto-test 365.24 KB 513.94 KB 102.79% (+/- <0.01%)
/course/student/auto-test/task 365.16 KB 513.85 KB 102.77% (+/- <0.01%)
/course/student/cross-check-review 405.6 KB 554.3 KB 110.86% (+/- <0.01%)
/course/student/cross-check-submit 420.82 KB 569.52 KB 113.90% (+/- <0.01%)
/course/student/dashboard 384.81 KB 533.51 KB 106.70% (+/- <0.01%)
/course/student/interviews 279.39 KB 428.08 KB 85.62% (+/- <0.01%)
/course/submit-scores 402.97 KB 551.67 KB 110.33% (+/- <0.01%)
/course/team-distributions 367.71 KB 516.41 KB 103.28% (+/- <0.01%)
/course/teams 389.96 KB 538.66 KB 107.73% (+/- <0.01%)
/cv/[uuid] 245.2 KB 393.9 KB 78.78% (+/- <0.01%)
/cv/edit 332.78 KB 481.48 KB 96.30% (+/- <0.01%)
/gratitude 264.99 KB 413.69 KB 82.74% (+/- <0.01%)
/heroes 286.1 KB 434.8 KB 86.96% (+/- <0.01%)
/job 220.04 KB 368.74 KB 73.75% (+/- <0.01%)
/profile/connection-confirmed 247.85 KB 396.54 KB 79.31% (+/- <0.01%)
/profile/notifications 322.74 KB 471.44 KB 94.29% (+/- <0.01%)
/registry/epamlearningjs 283.47 KB 432.16 KB 86.43% (+/- <0.01%)
/registry/mentor 344.14 KB 492.84 KB 98.57% (+/- <0.01%)
/registry/student 344.14 KB 492.84 KB 98.57% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@valerydluski valerydluski merged commit 09bba39 into master Aug 8, 2023
6 checks passed
@valerydluski valerydluski deleted the fix/update_api branch August 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants