Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test & refactor: fix tests warnings #2318

Merged
merged 8 commits into from
Oct 16, 2023
Merged

test & refactor: fix tests warnings #2318

merged 8 commits into from
Oct 16, 2023

Conversation

I-vasilich-I
Copy link
Contributor

@I-vasilich-I I-vasilich-I commented Oct 10, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ’‘ Background and solution

Ain't this beautiful? ;)
tests-running

BREAKING CHANGES:
in order to migrate to menu on Dropdown on Header component had to use :has() selector to style current route active menu item, which won't work on Firefox. Looks like menu has less flexibility compared to overlay, or I simply haven't found the way. So we either leave it that way, or should I change it back to overlay?
Screenshot from 2023-10-10 11-58-07

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 151.48 KB (🟑 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 286.82 KB 438.3 KB 87.66% (🟑 +0.01%)
/404 222.92 KB 374.4 KB 74.88% (+/- <0.01%)
/admin/courses 374.53 KB 526.01 KB 105.20% (🟑 +0.01%)
/admin/disciplines 320.88 KB 472.37 KB 94.47% (🟑 +0.01%)
/admin/discord-server 347.68 KB 499.16 KB 99.83% (🟑 +0.01%)
/admin/events 348.27 KB 499.75 KB 99.95% (+/- <0.01%)
/admin/mentor-registry 371.16 KB 522.64 KB 104.53% (+/- <0.01%)
/admin/notifications 386.42 KB 537.9 KB 107.58% (🟑 +0.01%)
/admin/prompts 328.07 KB 479.55 KB 95.91% (+/- <0.01%)
/admin/registrations 323.64 KB 475.12 KB 95.02% (🟑 +0.01%)
/admin/tasks 431.37 KB 582.85 KB 116.57% (+/- <0.01%)
/admin/user-group 371.89 KB 523.37 KB 104.67% (🟑 +0.01%)
/admin/users 269.34 KB 420.82 KB 84.16% (🟑 +0.01%)
/applicants 306.84 KB 458.32 KB 91.66% (🟑 +0.01%)
/course/admin/cross-check-table 424.35 KB 575.83 KB 115.17% (+/- <0.01%)
/course/admin/events 427.81 KB 579.29 KB 115.86% (+/- <0.01%)
/course/admin/interviews 370.86 KB 522.34 KB 104.47% (+/- <0.01%)
/course/admin/mentors 376.18 KB 527.66 KB 105.53% (🟑 +0.01%)
/course/admin/stage-interviews 372.53 KB 524.01 KB 104.80% (🟑 +0.01%)
/course/admin/students 384.81 KB 536.29 KB 107.26% (+/- <0.01%)
/course/admin/tasks 402.02 KB 553.5 KB 110.70% (🟑 +0.01%)
/course/admin/users 370.52 KB 522 KB 104.40% (+/- <0.01%)
/course/interview/[type]/feedback 336.61 KB 488.09 KB 97.62% (+/- <0.01%)
/course/mentor/auto-confirm 225.34 KB 376.82 KB 75.36% (🟑 +0.01%)
/course/mentor/confirm 288.95 KB 440.43 KB 88.09% (+/- <0.01%)
/course/mentor/dashboard 392.58 KB 544.06 KB 108.81% (🟑 +0.01%)
/course/mentor/expel-student 293.09 KB 444.57 KB 88.91% (🟑 +0.01%)
/course/mentor/feedback 294.66 KB 446.14 KB 89.23% (+/- <0.01%)
/course/mentor/interview-technical-screening 262.1 KB 413.58 KB 82.72% (+/- <0.01%)
/course/mentor/interview-wait-list 331.52 KB 483 KB 96.60% (🟑 +0.01%)
/course/mentor/interviews 343.08 KB 494.57 KB 98.91% (🟑 +0.01%)
/course/mentor/students 247.41 KB 398.89 KB 79.78% (+/- <0.01%)
/course/schedule 469.72 KB 621.21 KB 124.24% (+/- <0.01%)
/course/score 330.68 KB 482.16 KB 96.43% (🟑 +0.01%)
/course/student/auto-test 382.02 KB 533.5 KB 106.70% (🟑 +0.01%)
/course/student/auto-test/task 381.94 KB 533.42 KB 106.68% (🟑 +0.01%)
/course/student/cross-check-review 409.6 KB 561.08 KB 112.22% (+/- <0.01%)
/course/student/cross-check-submit 425.63 KB 577.11 KB 115.42% (🟑 +0.01%)
/course/student/dashboard 389.07 KB 540.55 KB 108.11% (🟑 +0.01%)
/course/student/interviews 299.78 KB 451.26 KB 90.25% (🟑 +0.01%)
/course/submit-scores 403.99 KB 555.47 KB 111.09% (🟑 +0.01%)
/course/team-distributions 373.42 KB 524.9 KB 104.98% (🟑 +0.01%)
/course/teams 417.97 KB 569.45 KB 113.89% (🟑 +0.01%)
/cv/[uuid] 239.48 KB 390.96 KB 78.19% (🟑 +0.01%)
/cv/edit 342.14 KB 493.62 KB 98.72% (🟑 +0.01%)
/gratitude 287.57 KB 439.05 KB 87.81% (+/- <0.01%)
/heroes 359.89 KB 511.37 KB 102.27% (🟑 +0.01%)
/job 223.54 KB 375.02 KB 75.00% (🟑 +0.01%)
/profile 405.47 KB 556.95 KB 111.39% (🟑 +0.01%)
/profile/connection-confirmed 263.46 KB 414.94 KB 82.99% (+/- <0.01%)
/profile/notifications 323.85 KB 475.33 KB 95.07% (+/- <0.01%)
/registry/epamlearningjs 286.59 KB 438.07 KB 87.61% (🟑 +0.01%)
/registry/mentor 337.61 KB 489.09 KB 97.82% (+/- <0.01%)
/registry/student 337.61 KB 489.09 KB 97.82% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@apalchys apalchys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@apalchys apalchys merged commit d7be41b into master Oct 16, 2023
6 checks passed
@apalchys apalchys deleted the test/test-warnings branch October 16, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants