feat: implement rs school app tests preview page #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apalchys
reviewed
Jul 9, 2024
| @RequiredRoles([Role.Admin, CourseRole.Manager]) | ||
| @ApiOperation({ operationId: 'getAllMinimizedRSSchoolAppTests' }) | ||
| @ApiOkResponse({ type: [MinimizedAutoTestTaskDto] }) | ||
| async getAllMinimizedRSSchoolAppTests() { |
There was a problem hiding this comment.
lets remove RSSchoolApp from the name as it looks redundant
There was a problem hiding this comment.
Also I suggest another name. minimized looks confusing here as it's usually used for describing UI patterns.
What about the following names:
getAllAutoTests()getBasicAutoTests()
apalchys
reviewed
Jul 9, 2024
|
|
||
| @Get('/:id') | ||
| @RequiredRoles([Role.Admin, CourseRole.Manager]) | ||
| @ApiOperation({ operationId: 'getRSSchoolAppTest' }) |
There was a problem hiding this comment.
since module called auto-test, I would name it as getAutoTest. Application name looks weird in the name
apalchys
reviewed
Jul 9, 2024
| constructor(task: Task) { | ||
| this.id = task.id; | ||
| this.name = task.name; | ||
| this.maxAttemptsNumber = Number(task?.attributes?.public?.maxAttemptsNumber); |
There was a problem hiding this comment.
Number(undefined) gives NaN. Please add handling when the value is undefined
| }); | ||
| } | ||
|
|
||
| public async getOne(id: number) { |
| export default function () { | ||
| return ( | ||
| <ActiveCourseProvider> | ||
| <SessionProvider allowedRoles={[CourseRole.Manager]} adminOnly> |
There was a problem hiding this comment.
<SessionProvider allowedRoles={[CourseRole.Manager]}>
| )} | ||
| {selectedTask?.descriptionUrl && ( | ||
| <Descriptions.Item label="Description URL"> | ||
| <a href={selectedTask?.descriptionUrl}>{selectedTask?.descriptionUrl}</a> |
There was a problem hiding this comment.
Suggested change
| <a href={selectedTask?.descriptionUrl}>{selectedTask?.descriptionUrl}</a> | |
| <a href={selectedTask?.descriptionUrl} target="_blank">{selectedTask?.descriptionUrl}</a> |
| {selectedTask?.discipline?.name && ( | ||
| <Descriptions.Item label="Discipline">{selectedTask?.discipline?.name}</Descriptions.Item> | ||
| )} | ||
| {selectedTask?.courses?.length && ( |
There was a problem hiding this comment.
Suggested change
| {selectedTask?.courses?.length && ( | |
| {selectedTask?.courses?.length > 0 && ( |
client/src/pages/admin/auto-test.tsx
Outdated
| export default function () { | ||
| return ( | ||
| <ActiveCourseProvider> | ||
| <SessionProvider allowedRoles={[CourseRole.Manager]} adminOnly> |
There was a problem hiding this comment.
Suggested change
| <SessionProvider allowedRoles={[CourseRole.Manager]} adminOnly> | |
| <SessionProvider allowedRoles={[CourseRole.Manager]}> |
valerydluski
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 Add
deploylabel if you want to deploy this Pull Request to staging environment🧑⚖️ Pull Request Naming Convention
area:*label(s)🤔 This is a ...
🔗 Related issue link
Describe the source of requirement, like related issue link.
💡 Background and solution
implement page with auto tesk cards, when preview button is pressed, modal with full data opens
☑️ Self Check before Merge