Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github PR in URL validation #2546

Merged
merged 4 commits into from
Nov 3, 2024
Merged

Conversation

AlreadyBored
Copy link
Contributor

@AlreadyBored AlreadyBored commented Nov 2, 2024

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

#2545

πŸ’‘ Background and solution

Added "Github PR in URL" validation that is disabled by default and can be combined with "Github Id in URL" option

Before
image
image

After
image
image

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

Copy link

github-actions bot commented Nov 2, 2024

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 111.45 KB (🟑 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/admin/events 363.18 KB 474.63 KB 94.93% (+/- <0.01%)
/admin/tasks 436.41 KB 547.86 KB 109.57% (🟑 +0.01%)
/course/admin/events 446.52 KB 557.97 KB 111.59% (🟑 +0.01%)
/course/admin/tasks 419.47 KB 530.92 KB 106.18% (🟑 +0.01%)
/course/schedule 488.9 KB 600.35 KB 120.07% (🟑 +0.01%)
/course/student/cross-check-submit 470.08 KB 581.53 KB 116.31% (🟑 +0.01%)
/course/student/dashboard 403.44 KB 514.89 KB 102.98% (+/- <0.01%)
/course/team-distributions 390.51 KB 501.96 KB 100.39% (+/- <0.01%)
/course/teams 437.05 KB 548.5 KB 109.70% (+/- <0.01%)
/profile 414.13 KB 525.58 KB 105.12% (+/- <0.01%)
/registry/epamlearningjs 299.2 KB 410.65 KB 82.13% (+/- <0.01%)
/registry/mentor 349.77 KB 461.22 KB 92.24% (🟑 +0.01%)
/registry/student 349.76 KB 461.21 KB 92.24% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@AlreadyBored AlreadyBored merged commit 9404a0b into master Nov 3, 2024
6 checks passed
@AlreadyBored AlreadyBored deleted the feat/2545-github-pr-validation branch November 3, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants