Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

262-feat: colorful icons in upcoming courses #331

Merged
merged 4 commits into from
Jun 24, 2024
Merged

262-feat: colorful icons in upcoming courses #331

merged 4 commits into from
Jun 24, 2024

Conversation

Wystov
Copy link
Collaborator

@Wystov Wystov commented Jun 22, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

In upcoming courses use same colorful icons as in course page
styles converted to module.

Related Tickets & Documents

Screenshots, Recordings

before
image

after
image

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

Summary by CodeRabbit

  • New Features

    • Enhanced course display interface with improved styling and image handling.
  • Refactor

    • Updated CourseCard component to use image sources instead of icon elements.
    • Refactored styling approach to use CSS modules and classNames for better maintainability.
  • Style

    • Introduced new stylesheet courses.module.scss for consistent and modular styling of course components.

Copy link
Contributor

coderabbitai bot commented Jun 24, 2024

Walkthrough

The recent changes involve updating the CourseCard.tsx and courses.tsx components to use classnames/bind for modular styling, and replacing black-and-white icons with colorized versions by switching from JSX elements to image source strings. A new SCSS module, courses.module.scss, has been introduced to handle the styles, ensuring components are now better organized and more visually appealing.

Changes

Files Summary
src/widgets/courses-school/ui/CourseCard.tsx Replaced icon JSX elements with image source strings, integrated classnames, imported Image component, used CSS modules for styling.
src/widgets/courses-school/ui/courses.tsx Refactored to utilize classnames/bind and courses.module.scss for styling, removed unused icon imports.
src/widgets/courses-school/ui/courses.module.scss Added new styles for the course display interface, focusing on titles, images, lists, cards, icons, and details.

Assessment against linked issues

Objective Addressed Explanation
Change black-and-white icons to colorized versions (#262) βœ…

Poem

Upon the screen, new colors bloom,
Where black and white once held their room.
With images so bright and clear,
The course cards now bring cheer.
A little change, a vibrant spree,
Enhancing learning joyously! 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5f7c63c and 481bd78.

Files selected for processing (3)
  • src/widgets/courses-school/ui/CourseCard.tsx (2 hunks)
  • src/widgets/courses-school/ui/courses.module.scss (1 hunks)
  • src/widgets/courses-school/ui/courses.tsx (3 hunks)
Files skipped from review due to trivial changes (1)
  • src/widgets/courses-school/ui/courses.module.scss
Additional comments not posted (7)
src/widgets/courses-school/ui/CourseCard.tsx (4)

1-1: Refactor imports to use new utilities and styles.

The imports have been updated to include classNames for conditional styling, Image for image handling, and styles from a new CSS module. This aligns with the PR's goal to enhance visual consistency.

Also applies to: 4-4, 7-7


13-13: Change in addFields type from JSX element to string for icons.

The icon property has been changed to iconSrc, which now expects a string URL instead of a JSX element. This modification is likely aimed at simplifying the rendering logic inside the component by directly using the Image component.


24-24: Updated component to use new iconSrc property.

The CourseCard component now uses the iconSrc property to render the course icon using the Image component. This change supports the use of colorized icons as per the PR's objectives and enhances the modularity of the component.

Also applies to: 29-29


27-35: Enhanced component structure with CSS modules.

The use of classNames.bind(styles) allows for more modular and maintainable style management. The structure of the CourseCard component is clear and well-organized, making good use of semantic HTML elements and accessibility features.

src/widgets/courses-school/ui/courses.tsx (3)

1-1: Refactor imports and styles to use CSS modules.

The imports have been updated to use classNames for conditional styling and styles from a newly created CSS module. This aligns with the PR's goal to standardize styling approaches across components.

Also applies to: 11-11


29-36: Ensure dynamic rendering of CourseCard with updated props.

The Courses component dynamically renders CourseCard components based on the data fetched. It correctly passes the new iconSrc and buttonText props, adapting the display based on the screen size. This is a good use of responsive design principles.


44-54: Structured and accessible layout for upcoming courses.

The layout uses semantic HTML and accessibility features like data-testid for easier testing. The use of classNames.bind(styles) ensures that the styles are applied correctly and are easy to manage.

@SpaNb4 SpaNb4 merged commit b21f509 into rolling-scopes:main Jun 24, 2024
4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 30, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change b/w icons to colorized
5 participants