Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

283-fix: fix 'https://rollingscopes.com/' redirect #332

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

natanchik
Copy link
Collaborator

@natanchik natanchik commented Jun 22, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

  1. Fixed redirect 'https://rollingscopes.com/' to 'https://rs.school/'. To check if the redirect works:
  1. Updated the names of web pages in the browser tab

  2. Removed #main from URLs.

Changes 2, 3 can be checked on the 'https://pr332.rs.school/' link.

Screenshots

Before
Screenshot 2024-06-24 195945

Now
image

Before
Screenshot 2024-06-24 200117

Now
Screenshot 2024-06-24 200235

Screenshot 2024-06-24 200248

Before
Screenshot 2024-06-24 201007

Now
image

Related Tickets & Documents

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

src/app/app.tsx Outdated Show resolved Hide resolved
src/app/layouts/base-layout/components/header/header.tsx Outdated Show resolved Hide resolved
src/app/layouts/base-layout/components/header/header.tsx Outdated Show resolved Hide resolved
src/widgets/mobile-view/ui/mobile-view.tsx Outdated Show resolved Hide resolved
src/widgets/mobile-view/ui/mobile-view.tsx Outdated Show resolved Hide resolved
src/widgets/mobile-view/ui/mobile-view.tsx Outdated Show resolved Hide resolved
src/widgets/mobile-view/ui/mobile-view.tsx Outdated Show resolved Hide resolved
src/widgets/mobile-view/ui/mobile-view.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also try to refactor scss to modules?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in another task with refactoring

@SpaNb4 SpaNb4 merged commit 47039c5 into main Jun 24, 2024
4 checks passed
@SpaNb4 SpaNb4 deleted the fix/283-fix-rollingscopes-redirect branch June 24, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix redirect from 'https://rollingscopes.com/' to 'https://rs.school/'
6 participants