345-refactor: Paragraph component refactor #358

ismoilkhon · 2024-07-02T04:37:57Z

What type of PR is this? (select all that apply)

Description

Paragraph component refactored

Related Tickets & Documents

#345

Screenshots, Recordings

Old

New

Added/updated tests?

👌 Yes
🙅‍♂️ No, because they aren't needed
🙋‍♂️ No, because I need help

Summary by CodeRabbit

Style
- Adjusted paragraph font sizes and line heights for better readability on different screen sizes.

coderabbitai · 2024-07-02T04:38:03Z

Walkthrough

The recent updates in src/shared/ui/paragraph/paragraph.scss refine the typography for the .paragraph class by adjusting the font sizes and line heights. These changes aim to enhance readability and coordination across various screen sizes, ensuring a consistent and user-friendly experience.

Changes

File Path	Change Summary
`src/shared/ui/paragraph/paragraph.scss`	Adjusted font size and line height for `.paragraph` class

Poem

In a world of code, where pixels sway,
Fonts and lines danced a new ballet.
From sixteen to fourteen, a graceful dive,
Eighteen to fourteen, they thrive.
Line heights slimming, now they gleam,
A typographic dream, reality we weave.

Tip

Early access features: enabled

We are currently testing the following features in early access:

OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues.
OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-02T04:39:38Z

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 80 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency	Version	Licenses
@next/env	14.2.3	MIT
@next/swc-linux-x64-gnu	14.2.3	MIT
@next/swc-linux-x64-musl	14.2.3	MIT
@playwright/test	1.44.1	Apache-2.0
@remix-run/router	1.16.1	MIT
@swc/counter	0.1.3	Apache-2.0
@swc/helpers	0.5.5	Apache-2.0
anymatch	3.1.3	ISC
binary-extensions	2.3.0	MIT
braces	3.0.3	MIT
brcast	3.0.2	MIT
busboy	1.6.0	MIT
caniuse-lite	1.0.30001616	CC-BY-4.0
chokidar	3.6.0	MIT
classnames	2.5.1	MIT
client-only	0.0.1	MIT
css-vendor	0.3.8	MIT
dayjs	1.11.11	MIT
fill-range	7.1.1	MIT
glob-parent	5.1.2	ISC
graceful-fs	4.2.11	ISC
hoist-non-react-statics	2.5.5	BSD-3-Clause
hyphenate-style-name	1.0.4	BSD-3-Clause
immutable	4.3.5	MIT
is-binary-path	2.1.0	MIT
is-function	1.0.2	MIT
is-glob	4.0.3	MIT
is-in-browser	1.1.3	MIT
is-number	7.0.0	MIT
is-plain-object	2.0.4	MIT
isobject	3.0.1	MIT
js-tokens	4.0.0	MIT
jss-camel-case	6.1.0	MIT
jss-compose	5.0.0	MIT
jss-default-unit	8.0.2	MIT
jss-expand	5.3.0	MIT
jss-extend	6.2.0	MIT
jss-global	3.0.0	MIT
jss-nested	6.0.1	MIT
jss-preset-default	4.5.0	MIT
jss-props-sort	6.0.0	MIT
jss-template	1.0.1	MIT
jss-vendor-prefixer	7.0.0	MIT
jss	9.8.7	MIT
loose-envify	1.4.0	MIT
nanoid	3.3.7	MIT
next	14.2.3	MIT
nextjs-toploader	1.6.12	MIT
normalize-path	3.0.0	MIT
nprogress	0.2.0	MIT
object-assign	4.1.1	MIT
picocolors	1.0.1	ISC
picomatch	2.3.1	MIT
playwright-core	1.44.1	Apache-2.0
playwright	1.44.1	Apache-2.0
postcss	8.4.31	MIT
prop-types	15.8.1	MIT
react-dom	16.14.0	MIT
react-dom	18.3.1	MIT
react-double-marquee	1.1.0	MIT
react-easy-swipe	0.0.21	MIT
react-is	16.13.1	MIT
react-json-pretty	2.2.0	MIT
react-jss	8.6.1	MIT
react-responsive-carousel	3.2.23	MIT
react-router-dom	6.23.1	MIT
react-router	6.23.1	MIT
react	16.14.0	MIT
react	18.3.1	MIT
readdirp	3.6.0	MIT
sass	1.77.4	Apache-2.0
scheduler	0.19.1	MIT
scheduler	0.23.2	MIT
source-map-js	1.2.0	BSD-3-Clause
streamsearch	1.1.0	MIT
styled-jsx	5.1.1	MIT
theming	1.3.0	MIT
to-regex-range	5.0.1	MIT
tslib	2.6.2	0BSD
warning	3.0.0	BSD-3-Clause

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1047c13 and 19d9315.

Files selected for processing (1)

src/shared/ui/paragraph/paragraph.scss (1 hunks)

Files skipped from review due to trivial changes (1)

src/shared/ui/paragraph/paragraph.scss

Quiddlee · 2024-07-02T08:34:19Z

src/shared/ui/paragraph/paragraph.scss

-    font-size: 16px;
-    line-height: 24px;
+    font-size: 14px;
+    line-height: 18px;
  }

-  font-size: 18px;
+  font-size: 14px;
  font-weight: $font-weight-regular;
-  line-height: 28px;
+  line-height: 18px;


Why did you change font size to 14px? I don't see any requirment for that in the task

Quiddlee · 2024-07-02T08:35:54Z

Please, change Related tickets section to be like this, with your issue number

github-actions · 2024-07-02T11:21:16Z

Lighthouse Report:

Performance: 84 / 100
Accessibility: 88 / 100
Best Practices: 93 / 100
SEO: 91 / 100

View detailed report

refactor: 345 - paragraph component refactored

19d9315

ismoilkhon requested review from andron13, dzmitry-varabei and SpaNb4 as code owners July 2, 2024 04:37

ismoilkhon linked an issue Jul 2, 2024 that may be closed by this pull request

FSD: shared folder refactor #345

Closed

13 tasks

github-actions bot added the preview label Jul 2, 2024

coderabbitai bot reviewed Jul 2, 2024

View reviewed changes

Quiddlee reviewed Jul 2, 2024

View reviewed changes

refactor: 345 - paragraph component replaced old version

b86f1da

apalchys requested a deployment to pr358 July 2, 2024 11:14 In progress

apalchys deployed to pr358 July 2, 2024 11:20 View deployment

ismoilkhon closed this Jul 3, 2024

ismoilkhon deleted the 345-fsd-shared-folder-refactor branch July 3, 2024 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

345-refactor: Paragraph component refactor #358

345-refactor: Paragraph component refactor #358

ismoilkhon commented Jul 2, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 2, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jul 2, 2024 •

edited

Loading

Third-party software list

coderabbitai bot left a comment

Quiddlee Jul 2, 2024

Quiddlee commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

345-refactor: Paragraph component refactor #358

345-refactor: Paragraph component refactor #358

Conversation

ismoilkhon commented Jul 2, 2024 • edited by coderabbitai bot Loading

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

Summary by CodeRabbit

coderabbitai bot commented Jul 2, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jul 2, 2024 • edited Loading

Qodana for JS

Third-party software list

coderabbitai bot left a comment

Choose a reason for hiding this comment

Quiddlee Jul 2, 2024

Choose a reason for hiding this comment

Quiddlee commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

ismoilkhon commented Jul 2, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 2, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

github-actions bot commented Jul 2, 2024 •

edited

Loading