Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

427-fix: Fix regex in pre-push hook #428

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

ansivgit
Copy link
Collaborator

@ansivgit ansivgit commented Jul 25, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Related Tickets & Documents

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

  • New Features

    • Enhanced branch naming flexibility by updating validation to require a minimum of three digits in branch names.
  • Bug Fixes

    • Improved the robustness of the pre-push hook by refining the regular expression for branch name validation.

@ansivgit ansivgit added bug Something isn't working high priority labels Jul 25, 2024
@ansivgit ansivgit self-assigned this Jul 25, 2024
@github-actions github-actions bot changed the title fix: 427 - regex in pre-push 427-fix: Fix regex in pre push hook Jul 25, 2024
@ansivgit ansivgit removed the preview label Jul 25, 2024
@ansivgit ansivgit changed the title 427-fix: Fix regex in pre push hook 427-fix: Fix regex in pre-push hook Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Qodana for JS

It seems all right πŸ‘Œ

No new problems were found according to the checks applied

πŸ’‘ Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 82 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@next/env 14.2.4 MIT
@next/swc-linux-x64-gnu 14.2.4 MIT
@next/swc-linux-x64-musl 14.2.4 MIT
@playwright/test 1.45.1 Apache-2.0
@remix-run/router 1.17.1 MIT
@swc/counter 0.1.3 Apache-2.0
@swc/helpers 0.5.5 Apache-2.0
anymatch 3.1.3 ISC
binary-extensions 2.3.0 MIT
braces 3.0.3 MIT
brcast 3.0.2 MIT
busboy 1.6.0 MIT
caniuse-lite 1.0.30001640 CC-BY-4.0
chokidar 3.6.0 MIT
class-variance-authority 0.7.0 Apache-2.0
classnames 2.5.1 MIT
client-only 0.0.1 MIT
clsx 2.0.0 MIT
css-vendor 0.3.8 MIT
dayjs 1.11.11 MIT
fill-range 7.1.1 MIT
glob-parent 5.1.2 ISC
graceful-fs 4.2.11 ISC
hoist-non-react-statics 2.5.5 BSD-3-Clause
hyphenate-style-name 1.1.0 BSD-3-Clause
immutable 4.3.6 MIT
is-binary-path 2.1.0 MIT
is-function 1.0.2 MIT
is-glob 4.0.3 MIT
is-in-browser 1.1.3 MIT
is-number 7.0.0 MIT
is-plain-object 2.0.4 MIT
isobject 3.0.1 MIT
js-tokens 4.0.0 MIT
jss-camel-case 6.1.0 MIT
jss-compose 5.0.0 MIT
jss-default-unit 8.0.2 MIT
jss-expand 5.3.0 MIT
jss-extend 6.2.0 MIT
jss-global 3.0.0 MIT
jss-nested 6.0.1 MIT
jss-preset-default 4.5.0 MIT
jss-props-sort 6.0.0 MIT
jss-template 1.0.1 MIT
jss-vendor-prefixer 7.0.0 MIT
jss 9.8.7 MIT
loose-envify 1.4.0 MIT
nanoid 3.3.7 MIT
next 14.2.4 MIT
nextjs-toploader 1.6.12 MIT
normalize-path 3.0.0 MIT
nprogress 0.2.0 MIT
object-assign 4.1.1 MIT
picocolors 1.0.1 ISC
picomatch 2.3.1 MIT
playwright-core 1.45.1 Apache-2.0
playwright 1.45.1 Apache-2.0
postcss 8.4.31 MIT
prop-types 15.8.1 MIT
react-dom 16.14.0 MIT
react-dom 18.3.1 MIT
react-double-marquee 1.1.0 MIT
react-easy-swipe 0.0.21 MIT
react-is 16.13.1 MIT
react-json-pretty 2.2.0 MIT
react-jss 8.6.1 MIT
react-responsive-carousel 3.2.23 MIT
react-router-dom 6.24.1 MIT
react-router 6.24.1 MIT
react 16.14.0 MIT
react 18.3.1 MIT
readdirp 3.6.0 MIT
sass 1.77.6 MIT
scheduler 0.19.1 MIT
scheduler 0.23.2 MIT
source-map-js 1.2.0 BSD-3-Clause
streamsearch 1.1.0 MIT
styled-jsx 5.1.1 MIT
theming 1.3.0 MIT
to-regex-range 5.0.1 MIT
tslib 2.6.3 0BSD
warning 3.0.0 BSD-3-Clause
Contact Qodana team

Contact us at [email protected]

@ansivgit ansivgit requested review from natanchik and Wystov July 25, 2024 17:06
@natanchik natanchik marked this pull request as ready for review July 25, 2024 17:07
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Walkthrough

Walkthrough

The changes involve an update to the regular expression in the Git pre-push hook to enhance branch name validation. The regex now mandates that branch names start with a minimum of three digits, thus improving flexibility while ensuring adherence to naming conventions. This adjustment also addresses cross-platform compatibility issues, particularly for Windows users.

Changes

Files Change Summary
.husky/pre-push Updated regex to require a minimum of three digits in branch names.

Assessment against linked issues

Objective Addressed Explanation
Ensure pre-push hook works correctly on Windows (#[427]) βœ…
Change regex for branch name validation (#[427]) βœ…

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec6cdba and 92d6c11.

Files selected for processing (1)
  • .husky/pre-push (1 hunks)
Files skipped from review due to trivial changes (1)
  • .husky/pre-push

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@Wystov Wystov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me.

@ansivgit ansivgit merged commit e883696 into main Jul 26, 2024
6 checks passed
@ansivgit ansivgit deleted the fix/427-fix-regex-in-pre-push-hook branch July 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotfix - fix Regex in pre-push husky hook
4 participants