Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

496-feat: Update active trainers #497

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

Wystov
Copy link
Collaborator

@Wystov Wystov commented Sep 5, 2024

What type of PR is this? (select all that apply)

  • 🍕 Feature

Description

Update active mentors for js-ru course

Related Tickets & Documents

Added/updated tests?

  • 👌 Yes
  • 🙅‍♂️ No, because they aren't needed
  • 🙋‍♂️ No, because I need help

Summary by CodeRabbit

  • New Features

    • Introduced a new mentor, "Сергей Кокшаров," for the JavaScript training program, complete with biography and photo.
  • Bug Fixes

    • Removed outdated mentor information for "Валерий Длусский" to ensure accuracy in mentor listings.

@Wystov Wystov self-assigned this Sep 5, 2024
@github-actions github-actions bot changed the title 496-feat: Update active mentors for js-ru course 496-feat: Update active trainers Sep 5, 2024
Copy link
Contributor

coderabbitai bot commented Sep 5, 2024

Walkthrough

Walkthrough

The changes involve updating the javaScriptRu array in the src/widgets/trainers/javascript-ru.data.ts file by removing the entry for "Валерий Длусский" and adding a new mentor, "Сергей Кокшаров." This update alters the available mentor information for JavaScript training courses.

Changes

File Change Summary
src/widgets/trainers/javascript-ru.data.ts Removed entry for "Валерий Длусский" and added entry for "Сергей Кокшаров."

Assessment against linked issues

Objective Addressed Explanation
Update information about trainers on courses (#496)
Update trainers on the JS/FE Course RU (#462) New trainers listed in the issue are not added.

Possibly related issues


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8cf4dd6 and 56b963b.

Files selected for processing (1)
  • src/widgets/trainers/javascript-ru.data.ts (3 hunks)
Additional comments not posted (2)
src/widgets/trainers/javascript-ru.data.ts (2)

5-5: Approved new import for mentor image.

The import for sergeyKoksharovImg is correctly added to support the new mentor's photo.


53-58: Review of new mentor entry: Сергей Кокшаров.

The entry for Сергей Кокшаров is correctly added with all necessary details such as name, bio, and photo. Ensure that the role description is intentionally left blank as it matches the style of other entries where the role is not specified.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 5, 2024

Lighthouse Report:

  • Performance: 93 / 100
  • Accessibility: 94 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Wystov Wystov merged commit cb03935 into main Sep 5, 2024
4 checks passed
@Wystov Wystov deleted the feat/496-update-active-trainers branch September 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update information about trainers on courses
4 participants