607-fix: Falling test

[Quiddlee]

What type of PR is this? (select all that apply)

• 🍕 Feature
• 🐛 Bug Fix
• 🚧 Breaking Change
• 🧑‍💻 Code Refactor
• 📝 Documentation Update

Description

Fix falling test case

Related Tickets & Documents

• Related Issue Fix falling test #607
• Closes Fix falling test #607

Screenshots, Recordings

Added/updated tests?

• 👌 Yes
• 🙅‍♂️ No, because they aren't needed
• 🙋‍♂️ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

• Tests
  • Updated the data mocking in tests for the UpcomingCourses component to improve accuracy.
  • Renamed variable for clarity and adjusted logic for counting course cards.
  • Ensured tests account for different screen sizes to verify component responsiveness.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the test file for the UpcomingCourses component, specifically upcoming-courses.test.tsx. It updates the mocking of data retrieval functions, replacing useDataByName with getActualData, which directly returns mockedData. Variable names and logic within the tests have been refined for clarity, including renaming courseCards to coursesList and adjusting assertions to reflect changes in the data structure. The tests for screen size rendering remain unchanged but now include explicit mock return values for varying screen widths.

Changes

File Path	Change Summary
src/widgets/upcoming-courses/ui/upcoming-courses.test.tsx	Updated mock from useDataByName to getActualData, renamed variables, adjusted logic for course count, and set specific mock return values for screen size.

Assessment against linked issues

Objective	Addressed	Explanation
Fix falling test (#607)	✅

Possibly related PRs

• 535-refactor: Widget School Courses #572: Refactors the UpcomingCourses component, which is directly related to the modifications made in the tests for this component.

Suggested reviewers

• dzmitry-varabei
• andron13
• natanchik
• SpaNb4
• ansivgit

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/widgets/upcoming-courses/ui/upcoming-courses.test.tsx (1)

65-66: Mocking simplified. Good job!

Direct mocking of getActualData improves test clarity.

Consider using vi.fn(() => mockedData) for brevity:

-  return { getActualData: vi.fn().mockImplementation(() => mockedData) };
+  return { getActualData: vi.fn(() => mockedData) };

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3539fb0 and 5e19ab5.

📒 Files selected for processing (1)

• src/widgets/upcoming-courses/ui/upcoming-courses.test.tsx (2 hunks)

🧰 Additional context used

🔇 Additional comments (2)

src/widgets/upcoming-courses/ui/upcoming-courses.test.tsx (2)

90-93: Improved variable naming and test logic. Nice work!

The changes clarify the test's intent and correctly account for the button in the course list.

Regarding the past comment about adding data-testid to each card: The current approach is acceptable for a quick fix. Consider adding data-testid to CourseCard in a future refactor for more robust testing.

---

Line range hint 108-111: Explicit mock values improve test clarity. Well done!

Setting explicit mock return values for useWindowSize enhances test readability and maintainability.

Also applies to: 122-125