Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

617-feat: Update js en trainers #618

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

KristiBo
Copy link
Collaborator

@KristiBo KristiBo commented Oct 22, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Related Tickets & Documents

Screenshots, Recordings

image

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

Summary by CodeRabbit

  • New Features
    • Introduced a new mentor, Natalia Volkova, to the JavaScript training program, enhancing the diversity of expertise available to learners.
    • Updated mentor details include her role, biography, and a linked photo.

@KristiBo KristiBo self-assigned this Oct 22, 2024
@github-actions github-actions bot changed the title 617-feat: Update js-en course team 617-feat: Update js en trainers Oct 22, 2024
@KristiBo KristiBo added the feature New feature or request label Oct 22, 2024
Copy link

Lighthouse Report:

  • Performance: 82 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Quiddlee Quiddlee marked this pull request as ready for review October 22, 2024 20:32
Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

πŸ“ Walkthrough

Walkthrough

The pull request adds a new mentor, Natalia Volkova, to the javaScriptEn array in the dev-data/javascript-en.data.ts file. This entry includes her name, role, a comprehensive biography detailing her background and career progression, and a link to her photo. No other entries in the array were modified.

Changes

File Change Summary
dev-data/javascript-en.data.ts Added a new entry for mentor Natalia Volkova with details.

Assessment against linked issues

Objective Addressed Explanation
Add new trainer Natalia Volkova (#617) βœ…

Possibly related PRs

  • 587-feat: Update course trainersΒ #588: This PR adds a new trainer entry to the javaScriptEn array, similar to the main PR which also adds a new trainer entry to the same array.
  • 597-feat: Update course trainersΒ #600: This PR introduces new entries to the javaScriptEn array, which includes adding multiple trainers, aligning with the main PR's focus on updating the trainer list in the same array.

Suggested reviewers

  • dzmitry-varabei
  • andron13
  • ansivgit
  • SpaNb4

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
dev-data/javascript-en.data.ts (1)

33-38: Suggested improvements for the bio text

The bio content needs some refinement:

  1. Grammar: "After completed RSS" should be "After completing RSS"
  2. Consider explaining the "RSS" abbreviation for newcomers
  3. Consider restructuring long sentences for better readability

Here's a suggested revision:

-    bio: 'Natalia is a self-learner and a career changer. Before joining IT she had 10+ years of experience in tutoring in Math, Finance, Economics and related subjects along with 5 years of experience as an Economist at the same time. After completed RSS Q3 2019, she rocked her career as a Frontend Developer, becoming a middle Frontend Developer by May 2020 (at Sberbank in Russia) and gaining a Senior level by June 2022 (at CRX Markets in Germany). Meanwhile, she also worked for EPAM in Russia, Callstack.io in Poland, Delivery Hero in Germany. Looking forward to sharing her knowledge and getting you started to work in IT.',
+    bio: 'Natalia is a self-learner and a career changer. Before joining IT, she combined 10+ years of experience tutoring Math, Finance, and Economics with a 5-year career as an Economist. After completing Rolling Scopes School (RSS) in Q3 2019, she accelerated through her Frontend Development career, reaching middle level by May 2020 and Senior level by June 2022. Her journey included roles at various European companies including Callstack.io (Poland), Delivery Hero and CRX Markets (Germany). She looks forward to sharing her knowledge and helping you start your IT career.',
πŸ“œ Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

πŸ“₯ Commits

Files that changed from the base of the PR and between 83ff456 and 117d291.

πŸ“’ Files selected for processing (1)
  • dev-data/javascript-en.data.ts (2 hunks)
🧰 Additional context used
πŸ”‡ Additional comments (2)
dev-data/javascript-en.data.ts (2)

6-6: LGTM: Import statement follows established patterns


33-38: Overall structure looks good

The new trainer entry follows the established pattern and includes all required fields.

@KristiBo KristiBo merged commit 12c225d into main Oct 22, 2024
6 checks passed
@KristiBo KristiBo deleted the feat/617-update-js-en-trainers branch October 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trainers on JS EN course
4 participants