-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
617-feat: Update js en trainers #618
Conversation
Lighthouse Report:
|
π WalkthroughWalkthroughThe pull request adds a new mentor, Natalia Volkova, to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Outside diff range and nitpick comments (1)
dev-data/javascript-en.data.ts (1)
33-38
: Suggested improvements for the bio textThe bio content needs some refinement:
- Grammar: "After completed RSS" should be "After completing RSS"
- Consider explaining the "RSS" abbreviation for newcomers
- Consider restructuring long sentences for better readability
Here's a suggested revision:
- bio: 'Natalia is a self-learner and a career changer. Before joining IT she had 10+ years of experience in tutoring in Math, Finance, Economics and related subjects along with 5 years of experience as an Economist at the same time. After completed RSS Q3 2019, she rocked her career as a Frontend Developer, becoming a middle Frontend Developer by May 2020 (at Sberbank in Russia) and gaining a Senior level by June 2022 (at CRX Markets in Germany). Meanwhile, she also worked for EPAM in Russia, Callstack.io in Poland, Delivery Hero in Germany. Looking forward to sharing her knowledge and getting you started to work in IT.', + bio: 'Natalia is a self-learner and a career changer. Before joining IT, she combined 10+ years of experience tutoring Math, Finance, and Economics with a 5-year career as an Economist. After completing Rolling Scopes School (RSS) in Q3 2019, she accelerated through her Frontend Development career, reaching middle level by May 2020 and Senior level by June 2022. Her journey included roles at various European companies including Callstack.io (Poland), Delivery Hero and CRX Markets (Germany). She looks forward to sharing her knowledge and helping you start your IT career.',
π Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
π Files selected for processing (1)
- dev-data/javascript-en.data.ts (2 hunks)
π§° Additional context used
π Additional comments (2)
dev-data/javascript-en.data.ts (2)
6-6
: LGTM: Import statement follows established patterns
33-38
: Overall structure looks goodThe new trainer entry follows the established pattern and includes all required fields.
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
Summary by CodeRabbit