628-fix: Video placeholder shown on prod

[Quiddlee]

What type of PR is this? (select all that apply)

• 🍕 Feature
• 🐛 Bug Fix
• 🚧 Breaking Change
• 🧑‍💻 Code Refactor
• 📝 Documentation Update

Description

Related Tickets & Documents

• Related Issue Video placeholder shown on prod #628
• Closes Video placeholder shown on prod #628

Screenshots, Recordings

Added/updated tests?

• 👌 Yes
• 🙅‍♂️ No, because they aren't needed
• 🙋‍♂️ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

• New Features

  • Updated logic in the AboutVideo component to determine the development environment using the NODE_ENV variable.

• Bug Fixes

  • Improved test cases for the AboutVideo component by aligning environment variable stubbing with standard practices.

• Chores

  • Removed unused environment variables and constants related to responsive design.
  • Deleted functions for generating responsive image sizes and srcset.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request involves the removal of environment variables and related constants used for responsive design configurations. Specifically, the .env file and several constants in src/shared/constants.ts have been deleted. Additionally, two helper functions for generating responsive image sizes and source sets have been removed. Modifications in the AboutVideo component update the environment checks from NEXT_PUBLIC_DEV to NODE_ENV, aligning with standard practices for environment management in testing and rendering logic.

Changes

File Path	Change Summary
.env	Removed environment variable declarations: NEXT_PUBLIC_TABLET, NEXT_PUBLIC_MOBILE, NEXT_PUBLIC_COMPRESS_QUALITY, NEXT_PUBLIC_DEV.
src/shared/constants.ts	Removed constants: TABLET_W, MOBILE_W, DESKTOP_W.
src/shared/helpers/generateSizes.ts	Removed method: export const generateSizes.
src/shared/helpers/generateSrcSet.ts	Removed method: export const generateSrcSet.
src/widgets/about-video/ui/about-video.tsx	Updated environment variable checks from NEXT_PUBLIC_DEV to NODE_ENV.
src/widgets/about-video/ui/about-video.test.tsx	Updated test cases to stub NODE_ENV instead of NEXT_PUBLIC_DEV.

Assessment against linked issues

Objective	Addressed	Explanation
Video placeholder shown on prod (#628)	✅

Possibly related PRs

• 498-refactor: Widget about video #538: The changes in this PR involve the removal of environment variables that were previously used to define breakpoints for responsive design, which directly relates to the removal of constants in src/shared/constants.ts that were derived from these environment variables.

Suggested reviewers

• SpaNb4
• dzmitry-varabei
• andron13
• natanchik

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.