Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

669-fix: Deprication warnings in tests #671

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

MielomankA
Copy link
Collaborator

@MielomankA MielomankA commented Dec 1, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers
vitejs/vite#18164 (comment)
https://vite.dev/config/shared-options#css-preprocessoroptions

Related Tickets & Documents

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] What gif best describes this PR or how it makes you feel?

giphy1

Summary by CodeRabbit

  • New Features

    • Added support for SCSS processing with the inclusion of the sass-embedded dependency.
    • Introduced new configuration options for CSS preprocessor settings in the testing framework.
  • Chores

    • Updated dependency management in package.json to include the new sass-embedded dependency.

@MielomankA MielomankA self-assigned this Dec 1, 2024
@MielomankA MielomankA requested review from SpaNb4 and Quiddlee December 1, 2024 19:17
package.json Outdated Show resolved Hide resolved
@ansivgit ansivgit marked this pull request as ready for review December 4, 2024 14:26
Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

πŸ“ Walkthrough
πŸ“ Walkthrough

Walkthrough

The pull request introduces a new dependency, "sass-embedded": "^1.82.0", to the devDependencies section of the package.json file, enhancing Sass processing capabilities. Additionally, the vitest.config.ts file has been updated to include a new css property with preprocessorOptions for the SCSS preprocessor, specifically setting the api option to 'modern-compiler'. No other modifications were made to existing configurations or dependencies.

Changes

File Change Summary
package.json Added "sass-embedded": "^1.82.0" to devDependencies.
vitest.config.ts Added css property with preprocessorOptions for SCSS.

Assessment against linked issues

Objective Addressed Explanation
Console does not display warnings (#669) ❓ It is unclear if the new dependency resolves deprecation warnings.

Possibly related PRs

Suggested labels

refactor, high priority

Suggested reviewers

  • dzmitry-varabei
  • andron13
  • ansivgit
  • natanchik
  • SpaNb4

πŸ“œ Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 4f8d88d and 33ace02.

β›” Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
πŸ“’ Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Dec 9, 2024

Lighthouse Report:

  • Performance: 52 / 100
  • Accessibility: 99 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

Copy link

github-actions bot commented Dec 9, 2024

Lighthouse Report:

  • Performance: 99 / 100
  • Accessibility: 99 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@MielomankA MielomankA merged commit fa742ed into main Dec 9, 2024
3 checks passed
@MielomankA MielomankA deleted the fix/669-deprication-warnings-in-tests branch December 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprication warnings in tests
6 participants