Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

694-refactor: Widget general #695

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

Quiddlee
Copy link
Member

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Related Tickets & Documents

Screenshots, Recordings

image

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Quiddlee Quiddlee self-assigned this Dec 16, 2024
@github-actions github-actions bot changed the title Refactor/694 widget general 694-refactor: Widget general Dec 16, 2024
@Quiddlee Quiddlee requested a review from Copilot December 16, 2024 12:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/widgets/general/general.scss: Language not supported
  • src/widgets/general/ui/general.module.scss: Language not supported
  • src/widgets/general/general.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/widgets/general/ui/general.test.tsx:13

  • Ensure that the 'WidgetTitle' component in 'general.tsx' has the 'data-testid' attribute set to 'widget-title'.
expect(screen.getByTestId('widget-title')).toBeVisible();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSD: Widget general
1 participant