796 - refactor: Change gray colors palette #805
Conversation
oibioib
requested review from
andron13,
dzmitry-varabei,
SpaNb4,
Quiddlee,
ansivgit and
natanchik
as code owners
📝 WalkthroughWalkthroughThe changes introduce a new section in the SCSS constants for gray colors, adding multiple variables that define various shades of gray using HSL values. Additionally, the hexadecimal color codes for existing technology theme variables (JavaScript, React, Angular, Node, AWS) have been modified to lowercase. These updates enhance the color palette available for styling without altering any application logic or control flow. Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/core/styles/_constants.scss (1)
77-78: Review Unused Variable.
The$color-bluevariable designated for link color does not appear to be used. Consider removing it to clean up the codebase if it's not referenced elsewhere.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/core/styles/_constants.scss(1 hunks)
🔇 Additional comments (2)
src/core/styles/_constants.scss (2)
50-61: Material Gray Palette Implementation.
The new gray color variables are clearly defined with HSL values and follow a consistent naming convention aligned with Material Design guidelines. This enhances clarity and maintainability.
66-75: Consistent Technology Theme Colors.
The hexadecimal codes for the technology-themed color variables are now in lowercase, which improves consistency and readability. Great job refining these values!
|
run visual now |
What type of PR is this? (select all that apply)
Description
Redefine the gray color constants according to the Material Design palette. And name the colors variables as color-gray-xxx.
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Additional notes
When I was working on this issue, I discovered:
The file /site/readme/styleguide-design.md must be updated according to the changes made.
In src/core/styles/_constants.scss there is a comment:
But there isn't such file or directory
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style