Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add disclaimer that avail-da tutorial is broken #486

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

MSevey
Copy link
Contributor

@MSevey MSevey commented Oct 11, 2024

Overview

Summary by CodeRabbit

  • Documentation
    • Added a warning disclaimer to the tutorial indicating it is currently broken, with a link to track fixes.
    • Retained instructional content on deploying a rollup to the Avail data availability network, including setup for an Avail light node and wallet funding on the Turing Testnet.

Copy link
Contributor

coderabbitai bot commented Oct 11, 2024

Walkthrough

The changes in this pull request introduce a warning disclaimer at the beginning of the avail-da.md tutorial, indicating that the tutorial is currently broken and linking to an issue for tracking fixes. The instructional content remains largely unchanged, covering the deployment of a rollup to the Avail data availability network, including steps for setting up an Avail light node and syncing it. The tutorial retains sections on cleaning previous chain history and configuring flags for data availability.

Changes

File Change Summary
tutorials/avail-da.md Added a warning disclaimer about the tutorial being broken and linked to an issue for tracking fixes. Content remains largely unchanged.

Possibly related PRs

  • Avail docs #392: This PR adds documentation for the Avail DA tutorial, which is directly related to the main PR's changes in the avail-da.md file.
  • update avail-da docs #411: This PR updates the avail-da.md tutorial, streamlining the installation process and providing new instructions, which aligns closely with the changes made in the main PR.

🐇 In the meadow where bunnies play,
A tutorial's guide has lost its way.
With a warning now at the start,
We hope for fixes, a brand new part!
But the steps to rollup still shine bright,
As we hop along, all feels just right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
tutorials/avail-da.md (2)

5-9: Enhance the disclaimer with more specific information

The addition of the disclaimer is appropriate and helpful. However, consider the following suggestions to make it more informative:

  1. Specify which parts of the tutorial are broken or what users might encounter if they attempt to follow it.
  2. Provide an estimated timeline for when the tutorial might be fixed, if possible.
  3. Consider adding a brief explanation of why the tutorial is currently broken (e.g., due to recent changes in the Avail network).

Additionally, it might be helpful to add a note at the end of the tutorial reminding users about the disclaimer, as they might miss it at the beginning.

Here's a suggested enhancement to the disclaimer:

:::warning Disclaimer
This tutorial is currently broken due to recent changes in the Avail network.
Specific issues include:
- [List specific parts that are not working]
- [Any known errors users might encounter]

We are actively working on fixing these issues. Follow the progress and estimated completion date in [rollkit/avail-da issue 57](https://github.com/rollkit/avail-da/issues/57).

In the meantime, please refer to our [alternative tutorial/documentation] for up-to-date information on deploying rollups to Avail.
:::

Line range hint 10-145: Update or annotate the tutorial content

While the disclaimer at the beginning is helpful, leaving the rest of the tutorial unchanged could lead to confusion. Consider the following suggestions:

  1. If possible, update the tutorial content to reflect the current state of the Avail network and fix any broken parts.

  2. If immediate updates are not feasible, consider adding inline warnings or notes throughout the tutorial to indicate which specific steps or sections are affected by the current issues.

  3. For each major section (e.g., "Running an Avail light node", "Cleaning previous chain history", etc.), add a note about its current status - whether it's still accurate or needs revision.

  4. If certain parts of the tutorial are still valid and useful, clearly mark these sections as such.

  5. Consider adding a "Known Issues" section near the top of the document, listing specific problems users might encounter when trying to follow this tutorial in its current state.

Here's an example of how you might annotate a section:

## 🪶 Running an Avail light node

:::warning
This section may be affected by the current issues. Please refer to [issue 57](https://github.com/rollkit/avail-da/issues/57) for the latest status.
:::

[existing content...]

By providing more context throughout the document, you can help users understand which parts of the tutorial they can still rely on and which parts they should approach with caution.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6356e62 and 8f3f635.

📒 Files selected for processing (1)
  • tutorials/avail-da.md (1 hunks)
🧰 Additional context used

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://rollkit.github.io/docs-preview/./pr-486/
on branch main at 2024-10-11 20:34 UTC

@MSevey MSevey merged commit 8940c1b into main Oct 15, 2024
10 checks passed
@MSevey MSevey deleted the avail-disclaimer branch October 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants