-
Notifications
You must be signed in to change notification settings - Fork 57
chore: remove gm tutorial reference from restart guide and clean up #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe document Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
guides/restart-rollup.md (2)
9-42
: Excellent improvements to clarity and user guidance!The changes in this section significantly enhance the guide's usability:
- The rephrasing in line 9 makes the instruction more straightforward.
- The added code examples (lines 14-16 and 29-31) provide clear, actionable steps.
- The detailed output logs (lines 21-25 and 36-39) help users understand what to expect.
- The additional explanation in line 42 about including flags is crucial for proper restart.
These modifications will greatly assist users in restarting their rollups correctly.
There's a minor grammatical issue in line 18. Consider changing "You would have see" to "You would have seen".
🧰 Tools
🪛 LanguageTool
[grammar] ~18-~18: The verb form ‘see’ does not seem to be suitable in this context.
Context: ...`bash rollkit startYou would have see output similar to:
bash I[2024-10-1...(HAVE_VB)
[style] ~27-~27: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... module=txindex height=7 ``` If you need to restart your rollup, you can run the sa...(REP_NEED_TO_VB)
[style] ~42-~42: This phrase is redundant. Consider writing “started”.
Context: ...additional flags that you used when you first started your rollup. For example, if you used t...(FIRST_BEGAN)
91-92
: Good addition of resource link and clarificationThe modification in these lines improves the guide by:
- Providing a clear link to a separate guide for configuring gas prices.
- Reinforcing the importance of increasing the gas fee to avoid errors.
This change helps keep the current guide focused while still ensuring users have access to necessary detailed information.
Consider removing "To reiterate" at the beginning of the sentence, as this is the first mention of increasing gas fee in this section. The sentence could start with "Before restarting the chain, you will need to increase the gas fee...".
🧰 Tools
🪛 LanguageTool
[style] ~91-~91: Consider a shorter alternative to avoid wordiness.
Context: ..., you will need to increase the gas fee in order to avoid aCode: 19
error. See the [How ...(IN_ORDER_TO_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- guides/restart-rollup.md (3 hunks)
🧰 Additional context used
🪛 LanguageTool
guides/restart-rollup.md
[grammar] ~18-~18: The verb form ‘see’ does not seem to be suitable in this context.
Context: ...`bash rollkit startYou would have see output similar to:
bash I[2024-10-1...(HAVE_VB)
[style] ~27-~27: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... module=txindex height=7 ``` If you need to restart your rollup, you can run the sa...(REP_NEED_TO_VB)
[style] ~42-~42: This phrase is redundant. Consider writing “started”.
Context: ...additional flags that you used when you first started your rollup. For example, if you used t...(FIRST_BEGAN)
[style] ~91-~91: Consider a shorter alternative to avoid wordiness.
Context: ..., you will need to increase the gas fee in order to avoid aCode: 19
error. See the [How ...(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (3)
guides/restart-rollup.md (3)
51-51
: Good update to maintain consistencyThe change in this line maintains consistency with earlier references to the quick start tutorial. This helps users connect this guide with their initial setup process, improving the overall coherence of the documentation.
87-87
: Improved generalization of instructionsThe modification in this line generalizes the instruction for stopping the rollup, making it applicable to all rollups rather than a specific chain. This change enhances the guide's versatility and simplifies the instructions without losing essential information.
Line range hint
1-91
: Excellent improvements to the guide's structure and contentThe changes made to this guide significantly enhance its overall quality and usability:
- The instructions for restarting a rollup are now more comprehensive and clear.
- The guide maintains a consistent style and tone throughout the document.
- It addresses both simple restart scenarios and more complex situations like running out of funds.
- The structure is logical and easy to follow, with clear section headings and subheadings.
- The modifications align well with the PR objectives of removing unnecessary references and improving clarity.
These improvements will greatly assist users in understanding and executing the process of restarting their Rollkit rollup under various circumstances.
🧰 Tools
🪛 LanguageTool
[style] ~8-~8: Consider a shorter alternative to avoid wordiness.
Context: ...where you need to restart your rollup. In order to restart your rollup, you simply need to...(IN_ORDER_TO_PREMIUM)
[grammar] ~18-~18: The verb form ‘see’ does not seem to be suitable in this context.
Context: ...`bash rollkit startYou would have see output similar to:
bash I[2024-10-1...(HAVE_VB)
[style] ~27-~27: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... module=txindex height=7 ``` If you need to restart your rollup, you can run the sa...(REP_NEED_TO_VB)
[style] ~42-~42: This phrase is redundant. Consider writing “started”.
Context: ...additional flags that you used when you first started your rollup. For example, if you used t...(FIRST_BEGAN)
replacing with #491 |
Overview
This PR removes reference to the GM tutorial in the restart your rollup how to guide. It also deduplicates some commands by referencing other sections and guides.
Summary by CodeRabbit