This repository has been archived by the owner on Oct 6, 2019. It is now read-only.
Include mapper logic into rom-mapper #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good start. You should be able to add a test which enables mapper config plugin in the configuration and try to register a mapper. |
|
@solnic I have added tests, to check that the configuration can register a Mapper. Also, remove an extra module for avoiding extra classes or modules. Do you have any more suggestions regarding this one? Feel free to comment. |
|
This is nice progress! Next step would be to port all these specs over here. They use a couple of shared contexts that you'll find right here. Once they are passing here, we should be fairly confident that the extension works in many cases. |
GustavoCaso
changed the title
|
This looks good man |
GustavoCaso
force-pushed
the
add_configuration_plugin_to_use_with_rom
branch
from
f4174dc to
45e6826
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@solnic
This is the combination of the PR in
romrom-rb/rom#387We can discuss further actions in other to make this work.