Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify original css #5

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

yurynix
Copy link
Contributor

@yurynix yurynix commented Sep 12, 2016

That is done so we would be able not to minify original css
at the loaders stage, so /*rtl:ignore*/ won't be stripped
Later, after RTL css is created, we should minify the
original chunk.

So to fix the issue described in #3:

  1. Upgrade to Webpack2 so UglifyJS plugin won't cause everything to be minified
  2. Don't use minimized on css loader
  3. Let webpack-rtl-plugin take care of the minification

That is done so we would be able not to minify original
at the loaders stage, so /*rtl:ignore*/ won't be stripped
Later, after RTL css is created, we should minify the
whole chunk
@romainberger romainberger merged commit 7123020 into romainberger:master Oct 25, 2016
@romainberger
Copy link
Owner

romainberger commented Oct 25, 2016

Thanks! I've published the fix in version 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants