Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example projects #1

Merged
merged 14 commits into from
Dec 9, 2023
Merged

Conversation

TobiTenno
Copy link
Member

@TobiTenno
Copy link
Member Author

TobiTenno commented Dec 3, 2023

the issue i fixed on 13c02b2 is an issue on https://romcal.js.org as well, so if you could fix that...

image example:
image

after:
image
obviously from the example, not from the deployed, but you get the point. this also adds the last day of the month to properly show at the bottom

TobiTenno added a commit to TobiTenno/romcal that referenced this pull request Dec 3, 2023
@TobiTenno
Copy link
Member Author

TobiTenno commented Dec 3, 2023

just realized and i'm kinda embarrassed, the version update and nvm parts totally don't work on the react-app, and yarn is just making it more jank. i'm drafting this for now.

@TobiTenno TobiTenno marked this pull request as draft December 3, 2023 05:24
just took some react-scripts and typescript updates

and linking to the updated romcal like the others
@TobiTenno TobiTenno marked this pull request as ready for review December 3, 2023 06:16
@TobiTenno

This comment was marked as outdated.

@TobiTenno TobiTenno changed the title update (most) example projects update example projects Dec 3, 2023
@TobiTenno
Copy link
Member Author

to simplify the above, i made a script, so the process now would be....

  • pull fix: add export keys, file path for esm files romcal#471, install, build
  • jump to this repo.
  • (assuming you're using react-app) cd into the example and run yarn dev:link
  • do not run any more yarn commands, this will wipe out the links
  • run yarn start.
  • ???
  • you should have a working, dev-updated example!

emagnier pushed a commit to romcal/romcal that referenced this pull request Dec 4, 2023
Copy link
Contributor

@emagnier emagnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for updating these example projects and for the improvements, they were in need of it. I'm a bit pressed for time at the moment to review and test. But, I plan to do so ASAP.

In the meantime, you can update romcal to version 3.0.0-dev.57 😃

@TobiTenno
Copy link
Member Author

Thank you very much for updating these example projects and for the improvements, they were in need of it. I'm a bit pressed for time at the moment to review and test. But, I plan to do so ASAP.

In the meantime, you can update romcal to version 3.0.0-dev.57 😃

Totally understand! I'll get them updated. I was wanting to fix whatever romcal.js.org renders from, given the really deceptive offset for the calendars.

@TobiTenno TobiTenno force-pushed the romcal-update-dev.56 branch from 3d381d4 to 3a323cd Compare December 4, 2023 22:59
Co-authored-by: Etienne Magnier <[email protected]>
@TobiTenno TobiTenno requested a review from emagnier December 4, 2023 23:00
@emagnier
Copy link
Contributor

emagnier commented Dec 5, 2023

the issue i fixed on 13c02b2 is an issue on https://romcal.js.org/ as well, so if you could fix that...

Indeed, the react-app example project serves as a base for generating the romcal.js.org site. Currently, I update this website manually (from this repo). It's something that will need to be automated one day, on every newly published version of romcal.

@TobiTenno
Copy link
Member Author

the issue i fixed on 13c02b2 is an issue on romcal.js.org as well, so if you could fix that...

Indeed, the react-app example project serves as a base for generating the romcal.js.org site. Currently, I update this website manually (from this repo). It's something that will need to be automated one day, on every newly published version of romcal.

If you're potentially open to it, I'd love to help automate it. I'm pretty good at automation and actions

@TobiTenno TobiTenno force-pushed the romcal-update-dev.56 branch from e4fd747 to 95599b7 Compare December 6, 2023 03:49
@TobiTenno TobiTenno force-pushed the romcal-update-dev.56 branch from 95599b7 to 5f12144 Compare December 6, 2023 04:31
@TobiTenno TobiTenno requested a review from emagnier December 6, 2023 04:33
@emagnier
Copy link
Contributor

emagnier commented Dec 9, 2023

If you're potentially open to it, I'd love to help automate it. I'm pretty good at automation and actions

That would be really awesome!! Feel free to suggest or challenge to do it in the right way. Currently, as you can see, the React project in this repository serves as a base, and the repository containing the compiled sources of the website is here. In my opinion, the website should have its own source code.

Just fyi, in the near future, I would like to take the time to document this project more, and possibly use Docusaurus (either by combining or migrating this current project, currently done with create-react-app, to Vite or Docusaurus... to be determined). But already, if the current version is automatically updated (as soon as a new version of Romcal is released), that would be very cool!

If you have any ideas, there are other things to automate as well, for example, an automatic changelog (based on Semantic Commit Messages).

FYI, I am currently in the midst of moving, so I will be a bit slow to respond in the coming days.

@emagnier
Copy link
Contributor

emagnier commented Dec 9, 2023

I'm merging your PR. Thank you for all the work you've done. I'll deploy romcal.js.org as soon as possible (I'm not on my computer right now, but I'll keep you posted as soon as it's done).
And I'll also test the date offset feature. If there's a need for a new fix, we can reopen a PR, no problem.

@emagnier emagnier merged commit 9967dfa into romcal:main Dec 9, 2023
@TobiTenno
Copy link
Member Author

I'm merging your PR. Thank you for all the work you've done. I'll deploy romcal.js.org as soon as possible (I'm not on my computer right now, but I'll keep you posted as soon as it's done).

And I'll also test the date offset feature. If there's a need for a new fix, we can reopen a PR, no problem.

Sounds good. I'm also on the Servus Dei discord server as tobiah, if we ever would prefer something more speedy for contact. The only problem I'd have for updating romcal.js.org more automatically is your extra components that don't seem to live in any repository I've seen.

@TobiTenno TobiTenno deleted the romcal-update-dev.56 branch December 10, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants