-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update example projects #1
Conversation
TobiTenno
commented
Dec 3, 2023
- standardize version pinning for development
- upgrade to -dev.56
- fix date resolution 'weirdness' sometimes using the wrong day start
- update html page
- update express example, breaking change fix
- update fastify to v3.0.0-dev.54
- node 18 didn't resolve modules properly
fix date resolution 'weirdness' sometimes using the wrong day start
node 18 didn't resolve modules properly
the issue i fixed on 13c02b2 is an issue on https://romcal.js.org as well, so if you could fix that... after: |
fixes error found on romcal/romcal-examples#1
requires romcal/romcal#471
just realized and i'm kinda embarrassed, the version update and nvm parts totally don't work on the react-app, and yarn is just making it more jank. i'm drafting this for now. |
just took some react-scripts and typescript updates and linking to the updated romcal like the others
This comment was marked as outdated.
This comment was marked as outdated.
to simplify the above, i made a script, so the process now would be....
|
fixes error found on romcal/romcal-examples#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for updating these example projects and for the improvements, they were in need of it. I'm a bit pressed for time at the moment to review and test. But, I plan to do so ASAP.
In the meantime, you can update romcal to version 3.0.0-dev.57
😃
Totally understand! I'll get them updated. I was wanting to fix whatever romcal.js.org renders from, given the really deceptive offset for the calendars. |
3d381d4
to
3a323cd
Compare
Co-authored-by: Etienne Magnier <[email protected]>
Indeed, the |
If you're potentially open to it, I'd love to help automate it. I'm pretty good at automation and actions |
e4fd747
to
95599b7
Compare
95599b7
to
5f12144
Compare
That would be really awesome!! Feel free to suggest or challenge to do it in the right way. Currently, as you can see, the React project in this repository serves as a base, and the repository containing the compiled sources of the website is here. In my opinion, the website should have its own source code. Just fyi, in the near future, I would like to take the time to document this project more, and possibly use Docusaurus (either by combining or migrating this current project, currently done with create-react-app, to Vite or Docusaurus... to be determined). But already, if the current version is automatically updated (as soon as a new version of Romcal is released), that would be very cool! If you have any ideas, there are other things to automate as well, for example, an automatic changelog (based on Semantic Commit Messages). FYI, I am currently in the midst of moving, so I will be a bit slow to respond in the coming days. |
I'm merging your PR. Thank you for all the work you've done. I'll deploy romcal.js.org as soon as possible (I'm not on my computer right now, but I'll keep you posted as soon as it's done). |
Sounds good. I'm also on the Servus Dei discord server as tobiah, if we ever would prefer something more speedy for contact. The only problem I'd have for updating romcal.js.org more automatically is your extra components that don't seem to live in any repository I've seen. |