Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to dev.97, workspaces, simplify test run #14

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

TobiTenno
Copy link
Member

Copy link

github-actions bot commented Feb 11, 2025

Test Results

 6 files  +5  10 suites  +9   9s ⏱️ +9s
 4 tests +1   4 ✅ +1  0 💤 ±0  0 ❌ ±0 
10 runs  +7  10 ✅ +7  0 💤 ±0  0 ❌ ±0 

Results for commit 2283ca0. ± Comparison against base commit b24a2f4.

♻️ This comment has been updated with latest results.

@TobiTenno TobiTenno marked this pull request as ready for review February 18, 2025 00:00
@TobiTenno TobiTenno enabled auto-merge (squash) February 18, 2025 00:23
@TobiTenno TobiTenno changed the title fix: update to dev.95 fix: update to dev.97 Feb 18, 2025
@TobiTenno TobiTenno changed the title fix: update to dev.97 fix: update to dev.97, workspaces, simplify test run Feb 18, 2025
@TobiTenno
Copy link
Member Author

@emagnier @tukusejssirs whenever y'all get a chance, I've got the updates out. I included @emagnier's changes from #13 . sorry i've been so busy lately

- needs romcal/romcal#746
- feat: workspaces, dynamic start script
- ci: dynamize year in test
- ci: don't run on push, only pull_request
- ci: increase memory on cypress build
- ci: split run for react
  build is too heavy
- fix: port changes from #13
- ci: simplify run/install/build
- fix: prestart path to accomodate workspaces
- ci: publish all the results after tests are done
Copy link
Member

@tukusejssirs tukusejssirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks.

Co-authored-by: Tukusej’s Sirs <[email protected]>
Copy link
Member

@tukusejssirs tukusejssirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @TobiTenno! 🙏

@TobiTenno TobiTenno merged commit ff1da3c into main Feb 18, 2025
11 checks passed
@TobiTenno TobiTenno deleted the dev-95 branch February 18, 2025 15:42
@tukusejssirs
Copy link
Member

@TobiTenno, CI failed for react-app, (heap out of memory).

@TobiTenno
Copy link
Member Author

ack, i didn't update the last push CI, just the PR CI. i'll get that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants