Skip to content

Commit

Permalink
[CI]: Run ygnmi after pyangbind to avoid threadkill (openconfig#1045)
Browse files Browse the repository at this point in the history
Based on results in openconfig#1043 it
suggests an OOM issue.
  • Loading branch information
wenovus authored and romeyod committed Sep 19, 2024
1 parent 617fa6e commit 2759951
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -229,28 +229,28 @@ steps:
waitFor: ['validator prep', 'go path creation', 'oc-pyang']
id: 'goyang-ygot'

############### YGNMI ###############
############### PYANG ###############
- name: 'us-west1-docker.pkg.dev/$PROJECT_ID/models-ci/models-ci-image'
entrypoint: 'bash'
args: ['-c', "/go/src/github.com/openconfig/models-ci/validators/ygnmi/test.sh"]
args: ['-c', '/go/src/github.com/openconfig/models-ci/validators/pyang/test.sh']
secretEnv: ['GITHUB_ACCESS_TOKEN']
volumes:
- name: 'gopath'
path: /go
env:
- 'GOPATH=/go'
- '_PR_NUMBER=$_PR_NUMBER'
- '_MODEL_ROOT=$_MODEL_ROOT'
- 'COMMIT_SHA=$COMMIT_SHA'
- '_REPO_SLUG=$_REPO_SLUG'
- 'BRANCH_NAME=$BRANCH_NAME'
waitFor: ['validator prep', 'go path creation', 'oc-pyang']
id: 'ygnmi'
volumes:
- name: 'gopath'
path: /go
waitFor: ['validator prep', 'oc-pyang']
id: 'pyang'

############### PYANG ###############
############### PYANGBIND ###############
- name: 'us-west1-docker.pkg.dev/$PROJECT_ID/models-ci/models-ci-image'
entrypoint: 'bash'
args: ['-c', '/go/src/github.com/openconfig/models-ci/validators/pyang/test.sh']
args: ['-c', '/go/src/github.com/openconfig/models-ci/validators/pyangbind/test.sh']
secretEnv: ['GITHUB_ACCESS_TOKEN']
env:
- 'GOPATH=/go'
Expand All @@ -263,25 +263,25 @@ steps:
- name: 'gopath'
path: /go
waitFor: ['validator prep', 'oc-pyang']
id: 'pyang'
id: 'pyangbind'

############### PYANGBIND ###############
############### YGNMI ###############
- name: 'us-west1-docker.pkg.dev/$PROJECT_ID/models-ci/models-ci-image'
entrypoint: 'bash'
args: ['-c', '/go/src/github.com/openconfig/models-ci/validators/pyangbind/test.sh']
args: ['-c', "/go/src/github.com/openconfig/models-ci/validators/ygnmi/test.sh"]
secretEnv: ['GITHUB_ACCESS_TOKEN']
volumes:
- name: 'gopath'
path: /go
env:
- 'GOPATH=/go'
- '_PR_NUMBER=$_PR_NUMBER'
- '_MODEL_ROOT=$_MODEL_ROOT'
- 'COMMIT_SHA=$COMMIT_SHA'
- '_REPO_SLUG=$_REPO_SLUG'
- 'BRANCH_NAME=$BRANCH_NAME'
volumes:
- name: 'gopath'
path: /go
waitFor: ['validator prep', 'oc-pyang']
id: 'pyangbind'
waitFor: ['validator prep', 'go path creation', 'oc-pyang', 'pyangbind'] # wait for pyangbind to avoid possible OOM.
id: 'ygnmi'

############### COMPATIBILITY REPORT ###############
- name: 'us-west1-docker.pkg.dev/$PROJECT_ID/models-ci/models-ci-image'
Expand Down

0 comments on commit 2759951

Please sign in to comment.