Add Import form to db views
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
requested changes
Apr 4, 2024
app/db.rb
Outdated
| redirect "db/host_names" | ||
| end | ||
|
|
||
| if host_name.save |
There was a problem hiding this comment.
I think the host_name.save is unnecessary, since HostName.import calls create(...) with the host name. Can probably simply the if statement to just a simple redirect "/db/host_names/#{host_name.id}".
app/db.rb
Outdated
| post '/db/host_names/import' do | ||
| begin | ||
| host_name = Ronin::DB::HostName.import(params[:host_name]) | ||
| rescue ArgumentError => e |
There was a problem hiding this comment.
I try to avoid single letter variable names and prefer to use error instead of e.
views/db/credentials/show.erb
Outdated
| <h1>Credential: <%=h @password %></h1> | ||
| <%= partial(:delete, record: @password, path: "credentials") %> | ||
| <h1>Credential: <%=h @credential %></h1> | ||
| <%= partial(:delete, record: @credential, path: "credentials") %> |
There was a problem hiding this comment.
This could probably be a separate commit.
views/db/organizations/index.erb
Outdated
| <p><a href="/db/organizations/<%=h organization.id %>"><%=h organization %></a></p> | ||
| <% end %> | ||
|
|
||
| <%= partial(:pagination, pagy: @pagy) %> |
There was a problem hiding this comment.
I'm guessing your editor automatically re-indented this code?
views/db/passwords/index.erb
Outdated
| <li><a href="/">Home</a></li> | ||
| <li><a href="/db">Database</a></li> | ||
| </ul> | ||
| </nav> | ||
| <% end %> |
There was a problem hiding this comment.
I'm guessing your editor automatically re-indented stuff?
There was a problem hiding this comment.
No, I did it intentionally :D
postmodern
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93