Switch back to using explicit bitwise operations.

* Explicit bitwise operations are more understandable than the `Integer#allbits?` / `Integer#nobits?` methods. * Released rubocop-ronin 0.2.7 which disables `Style/BitwisePredicate`.
ronin-rb · Nov 21, 2024 · 3893b4d · 3893b4d
1 parent 654b9f2
commit 3893b4d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/ronin/support/network/ip.rb b/lib/ronin/support/network/ip.rb
@@ -289,7 +289,7 @@ def self.extract(text,version=nil,&block)
         #
         def broadcast?
           # NOTE: IPv6 does not have broadcast addresses
-          ipv4? && @addr.allbits?(0xff) # IPv4: A.B.C.255
+          ipv4? && (@addr & 0xff) == 0xff
         end
 
         #
@@ -309,7 +309,7 @@ def broadcast?
         #   # => false
         #
         def logical?
-          ipv4? && @addr.nobits?(0xff) # IPv4: A.B.C.0
+          ipv4? && (@addr & 0xff) == 0x00
         end
 
         #