Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Husky/pre-commit and use for bun run changeset suggestion #125

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

sammoore
Copy link
Member

@sammoore sammoore commented Dec 18, 2023

This PR is a subset of the changes in #102 for better scoping / merge-ability.

  • Fix Husky per the Husky v4 -> v8 migration guide -- mostly moving the husky directive/script out of package.json into the .husky/ folder.
    • Along the way, disable/remove pretty-quick, the only thing we were using with Husky before Husky stopped working awhile ago, because pretty-quick no longer working due to Prettier v3 (pending further changes currently drafted in Improve Prettier, formatting enforcement #102).
  • Ask the user on pre-commit (via Husky), if they modified anything under cli/, whether they would like to run bun run changeset automatically via a (Y/n) prompt.

All prettier-related changes from #102 will arrive in another, separate PR.

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-expo-stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 5:42am
create-expo-stack-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 5:42am

Copy link

vercel bot commented Dec 18, 2023

@sammoore is attempting to deploy a commit to the ronin-tech Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@danstepanov danstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danstepanov danstepanov merged commit 2170015 into roninoss:main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants