Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical / Common-sense Assessment
Please review this PR with as much detail as possible in the time given to you. You can be as harsh as you like; I didn't write it 😛
For the 2 most egregious problems that you detect, please provide a rough outline of how you would've done it instead. Pseudo-code is encouraged but not necessary.
To run this branch in a dev environment, please follow the instructions in the repo README.
The first commit adds in some administrative stuff so I would recommend only reviewing the commits after.
Context
A programmer named X Æ A-12 was tasked with the following:
Given a database of daily stock prices, a rebalancing frequency (in this example, weekly), and a target % portfolio allocation, calculate the actual daily % allocation of two stocks in a portfolio. This Investopedia article may be helpful for providing context.
From the article:
The above example shows how to rebalance one year later back to your target allocation. What we want to do in this PR is also show all the intermediate allocations for every day between the rebalancing dates.
After some time X Æ A-12 asks you to review this PR that they've been working on...