Fix for keybindings firing while inside menus. #10
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers, have been meaning to get around to this. |
|
Hey, had a typo when I pushed that to git last night (downside to working on this stuff at 2am heh). Line 64 should be using a colon instead of a dot. I just caught this typo about 5 minutes ago. Sorry bout that! Everything else should be fine! I'm gonna update my fork here in a a minute. |
|
Alright I updated my fork and it seems to have also updated this PR. Didn't know it would do that, cool stuff. |
|
No worries at all. I'll be merging your commits so you get credit for your help in git history, but will be doing a commit pass on top of this too to check everything and add some related refactors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keybindings fire while inside menus. Add a check for whether the UI is using input, in which case we don't want to fire these keybindings. This includes chat, pause menu, inventory menu in the Psykhanium, etc.
The ducks got lost when opening the file locally. Leaving the re-adding up to you rather than linking two commits for you to look over.