[bitcoin] Cli bitcoin address binding #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -5,7 +5,8 @@ use crate::cli_types::CommandAction; | |||
| use crate::commands::account::commands::balance::BalanceCommand; | |||
| use async_trait::async_trait; | |||
| use commands::{ | |||
| create::CreateCommand, list::ListCommand, nullify::NullifyCommand, switch::SwitchCommand, | |||
| binding::BindingCommand, create::CreateCommand, list::ListCommand, nullify::NullifyCommand, | |||
There was a problem hiding this comment.
Is there an option for updating the existing or created bitcoin address on Rooch?
| use bitcoincore_rpc::{Auth, Client, RpcApi}; | ||
| use clap::Parser; | ||
| use rooch_types::{ | ||
| address::{BitcoinAddress, MultiChainAddress, RoochAddress}, |
There was a problem hiding this comment.
Isn't it included BitcoinAddress to the MultiChainAddress? We were using only two types of addresses before.
|
|
||
| #[clap( | ||
| long, | ||
| env = "BITCOIN_RPC_URL", |
There was a problem hiding this comment.
Is there a plan to include Bitcoin Lightning RPC URL?
| )?; | ||
| let wallet_context = self.context_options.build()?; | ||
| let sender = wallet_context.resolve_address(self.tx_options.sender)?; | ||
| match self.l1_chain { |
There was a problem hiding this comment.
Is there a binding for Ethereum L1?
| @@ -2,6 +2,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| pub mod balance; | |||
There was a problem hiding this comment.
I suggest this mod to be renamed to inquire? Never mind if it's only for inquire about account balance.
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
pushed a commit
to ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4/rooch
that referenced
this pull request
Jan 15, 2024
ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
force-pushed
the
cli_bitcoin_address_binding
branch
from
9be4751 to
aefcdff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR