feat(rooch-da): add repair command for segment issues #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `open_rooch_db` and `open_inner_rocks` functions to support RocksDB operations. Updated dependencies in `Cargo.toml` and `Cargo.lock` to include RocksDB.
Introduce a new `RocksAccumulatorStore` implementation for `AccumulatorTreeStore` using RocksDB. This includes support for node retrieval, batch operations, and node deletion.
Improve the efficiency and clarity of batch creation by passing `RoochKeyPair` and `sequencer_key` as references. This avoids unnecessary copying and enhances memory management across related methods.
Refactored multiple commands to utilize `open_rooch_db` instead of `init` for improved modularity and code clarity. Removed the `init` function and related dependencies, simplifying command logic and reducing redundancy.
Introduce CpCfCommand to facilitate copying RocksDB column families between databases. Supports specifying source, destination, and column family name for efficient data migration.
Add a new RepairCommand to address tx_order inconsistencies in data availability segments. This feature includes tools for repairing and verifying segments with enhanced integrity checks without persisting changes.
Improve error handling during transaction reversal for DA failures. Log detailed errors when reverting fails, enabling easier monitoring and debugging.
Refactor loop to ensure the timestamp of the previous transaction is found. Prevents panics when a transaction doesn't exist and returns the minimum timestamp instead.
Skip processing transactions with duplicate hashes to avoid inconsistencies during execution. Also, adjust logging for L2 transaction execution failures by refining the logging function.
Refactored `cp_cf` command to use a `for` loop instead of a manual loop for iterating over RocksDB entries. This simplifies the code and improves readability without changing functionality.
Renamed constant `TX_ORDER_WITH_DUP_HASH_ISSUE` to `tx_order_with_dup_hash_issue` for alignment with Rust naming conventions. Improves code readability and maintainability.
Refactored the logic for retrieving the transaction timestamp to use `if let` for improved clarity and conciseness. This eliminates unnecessary unwrapping of the option.
popcnt1
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jolestar
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(rooch-da): handle duplicate transaction hashes
Skip processing transactions with duplicate hashes to avoid inconsistencies during execution.
fix(rooch-pipeline-processor): handle tx revert errors gracefully
Improve error handling during transaction reversal for DA failures. Log detailed errors when reverting fails, enabling easier monitoring and debugging.
feat(rooch-da): add repair command for segment issues
Add a new RepairCommand to address tx_order inconsistencies in data availability segments. This feature includes tools for repairing and verifying segments with enhanced integrity checks without persisting changes.
feat(rooch-db): add CpCfCommand for column family migration
Introduce CpCfCommand to facilitate copying RocksDB column families between databases. Supports specifying source, destination, and column family name for efficient data migration.
feat(moveos): add RocksDB-backed accumulator tree store
Introduce a new
RocksAccumulatorStoreimplementation forAccumulatorTreeStoreusing RocksDB. This includes support for node retrieval, batch operations, and node deletion.feat(rooch): add utility functions for RocksDB integration
Introduce
open_rooch_dbandopen_inner_rocksfunctions to support RocksDB operations. Updated dependencies inCargo.tomlandCargo.lockto include RocksDB.