224 feat(documents): added button to move folders to other folders #230
+63
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikjelle
commented
Jan 18, 2025
| // if parent is null/root it can always be moved, else check if its not being moved into itself. | ||
| if ($parent != null && folderInsideSelfOrChildren($folder, $parent)) | ||
| { | ||
| $this->addFlash('warning', 'Je kunt deze map niet naar zichzelf verplaatsen.'); |
There was a problem hiding this comment.
Is dit geimplementeerd? Ik zie dat het vaker gebruik wordt in de code, maar ik zag de melding niet tijdens het developen.
There was a problem hiding this comment.
Ik denk het niet. Ik weet niet precies hoe dit bij Symfony werkt, maar bij Django en Flask moet je expliciet in je html templates door de flash messages heen gaan om ze te printen (of op een andere manier consumen). Dat hebben we volgens mij maar op een paar plekken.
Volgens mij zit het wel in het accepteren van lidmaatschapsaanmeldingen, dus je zou daar even kunnen kijken.
There was a problem hiding this comment.
Ik heb de flash messages toegevoegd in 46f108f
pingiun
force-pushed
the
224-move-folders
branch
from
f42f692 to
77c0797
Compare
Gwildor
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #224