feature/property-description-builder

lib/concierge/property_description.rb

@@ -0,0 +1,57 @@
+module Concierge
+
+  # +Concierge::PropertyDescription+
+  #
+  # If property does not have description this class helps to build
+  # it from property attributes. If some of required attributes is missed empty string will be returned.
+  #
+  # Usage:
+  #
+  #  PropertyDescription.new(property).build # => String
+  class PropertyDescription
+    attr_reader :property
+
+    def initialize(property)
+      @property = property
+    end
+
+    def build
+      result = ''
+      if valid?
+        result = "This is a charming #{property.type} in #{property.city}, which can accommodate "\
+        "#{pluralize(property.max_guests, 'guest', 'guests')}."
+
+        rooms_part_start = if property.surface
+                             "The #{property.surface} square metres apartment"
+                           else
+                             "It"
+                           end
+
+        result += "#{rooms_part_start} has #{pluralize(property.number_of_bedrooms, 'bedroom', 'bedrooms')} and "\
+          "#{pluralize(property.number_of_bathrooms, 'bathroom', 'bathrooms')}."
+      end
+
+      result
+    end
+
+    private
+
+    def valid?
+      property.type &&
+        property.city &&
+        property.max_guests.to_i > 0 &&
+        property.number_of_bedrooms.to_i > 0 &&
+        property.number_of_bathrooms.to_i > 0
+    end
+
+    def pluralize(n, singular, plural=nil)
+      if n == 1
+        "1 #{singular}"
+      elsif plural
+        "#{n} #{plural}"
+      else
+        "#{n} #{singular}s"
+      end
+    end
+  end
+end

lib/concierge/suppliers/poplidays/mappers/roomorama_property.rb

@@ -55,6 +55,9 @@ def build(property, details, availabilities, extras)
         set_security_deposit!(roomorama_property, details)
         set_cleaning_info!(roomorama_property, extras)
 
+        if roomorama_property.description.to_s.empty?
+          roomorama_property.description = description_builder(roomorama_property).build
+        end
         Result.new(roomorama_property)
       end
 
@@ -98,7 +101,7 @@ def set_security_deposit!(roomorama_property, details)
       end
 
       def build_descriptions(details)
-        [details.get('description.indoor'), details.get('description.outdoor')].compact.join("\n\n")
+        [details.get('description.indoor'), details.get('description.outdoor')].select { |d| !d.to_s.empty? }.join("\n\n")
       end
 
       def set_images!(result, details)
@@ -225,6 +228,10 @@ def calc_cleaning_extra_price(cleaning_extra)
         price['value'] if price
       end
 
+      def description_builder(property)
+        Concierge::PropertyDescription.new(property)
+      end
+
       def to_stay(availability, mandatory_services)
         Roomorama::Calendar::Stay.new(
           {

spec/lib/concierge/property_description_spec.rb

@@ -0,0 +1,70 @@
+require "spec_helper"
+
+RSpec.describe Concierge::PropertyDescription do
+
+  describe "#build" do
+    context 'when property does not have required fields' do
+      it "returns empty string if property does not have required fields" do
+        p = Roomorama::Property.new('15')
+
+        subject = described_class.new(p)
+        expect(subject.build).to eq ''
+      end
+
+      it "returns empty string if property does not have required fields" do
+        p = Roomorama::Property.load(
+          {
+            identifier: '15',
+            disabled: true, # to make property valid
+            type: 'apartment',
+            max_guests: 4,
+            number_of_bedrooms: 3,
+            number_of_bathrooms: 2
+          }
+        ).value
+
+        subject = described_class.new(p)
+        expect(subject.build).to eq ''
+      end
+    end
+
+    context 'when property does not have surface' do
+      it "returns appropriate description" do
+        p = Roomorama::Property.load(
+          {
+            identifier: '15',
+            disabled: true, # to make property valid
+            type: 'apartment',
+            max_guests: 4,
+            city: 'Omsk',
+            number_of_bedrooms: 3,
+            number_of_bathrooms: 2
+          }
+        ).value
+
+        subject = described_class.new(p)
+        expect(subject.build).to eq 'This is a charming apartment in Omsk, which can accommodate 4 guests.It has 3 bedrooms and 2 bathrooms.'
+      end
+    end
+
+    context 'when property has all required fields' do
+      it "returns appropriate description" do
+        p = Roomorama::Property.load(
+          {
+            identifier: '15',
+            disabled: true, # to make property valid
+            type: 'apartment',
+            max_guests: 4,
+            city: 'Omsk',
+            number_of_bedrooms: 3,
+            number_of_bathrooms: 2,
+            surface: 56
+          }
+        ).value
+
+        subject = described_class.new(p)
+        expect(subject.build).to eq 'This is a charming apartment in Omsk, which can accommodate 4 guests.The 56 square metres apartment has 3 bedrooms and 2 bathrooms.'
+      end
+    end
+  end
+end