Skip to content

Add tests for Real32Quant #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions types/fundamental/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
* [`misc`](misc): `Bit`, `Byte`, `Char`
* [`real`](real): `Real{16,32,64}`, `SplitReal{32,64}`
* [`real32trunc`](real32trunc): `Real32Trunc`
* [`real32quant`](real32quant): `Real32Quant`

__Covered under a different category:__
* `[Split]Index{32,64}`: with [`std::string`](../string) and [`std::vector`](../vector)
* `Switch`: with [`std::variant`](../variant)

__Missing:__
* `Real32Quant`
21 changes: 21 additions & 0 deletions types/fundamental/real32quant/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Real Column Types with variable width and value range

## Fields

* `FloatReal32Quant1`
* `FloatReal32Quant8`
* `FloatReal32Quant32` with value range `[-pi, pi]` (where `pi` is truncated to `float`)
* `DoubleReal32Quant8`
* `DoubleReal32Quant20`
* `DoubleReal32Quant32` with value range `[-100, 25]`

with the corresponding field types, column type `Real32Quant`, with corresponding bit width
and a value range of `[-1, 1]` unless noted otherwise.

## Entries

1. Ascending values
2. All 1s in the mantissa
3. Middle values of the fields' value range
4. Min values of the fields' value range
5. Max values of the fields' value range
57 changes: 57 additions & 0 deletions types/fundamental/real32quant/read.C
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
#include <ROOT/REntry.hxx>
#include <ROOT/RNTupleReader.hxx>

using ROOT::Experimental::REntry;
using ROOT::Experimental::RNTupleReader;

#include <fstream>
#include <ios>
#include <ostream>
#include <string>
#include <string_view>

template <typename T>
static void PrintRealValue(const REntry &entry, std::string_view name,
std::ostream &os, bool last = false) {
T value = *entry.GetPtr<T>(name);
os << " \"" << name << "\": \"" << value << "\"";
if (!last) {
os << ",";
}
os << "\n";
}

void read(std::string_view input = "types.fundamental.real32quant.root",
std::string_view output = "types.fundamental.real32quant.json") {
std::ofstream os(std::string{output});
// Print floating-point numbers as hexadecimal literals.
os << std::hexfloat;
os << "[\n";

auto reader = RNTupleReader::Open("ntpl", input);
auto &entry = reader->GetModel().GetDefaultEntry();
bool first = true;
for (auto index : *reader) {
reader->LoadEntry(index);

if (first) {
first = false;
} else {
os << ",\n";
}
os << " {\n";

PrintRealValue<float>(entry, "FloatReal32Quant1", os);
PrintRealValue<float>(entry, "FloatReal32Quant8", os);
PrintRealValue<float>(entry, "FloatReal32Quant32", os);
PrintRealValue<double>(entry, "DoubleReal32Quant1", os);
PrintRealValue<double>(entry, "DoubleReal32Quant20", os);
PrintRealValue<double>(entry, "DoubleReal32Quant32", os, /*last=*/true);

os << " }";
// Newline is intentionally missing, may need to print a comma before the
// next entry.
}
os << "\n";
os << "]\n";
}
96 changes: 96 additions & 0 deletions types/fundamental/real32quant/write.C
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
#include <ROOT/RField.hxx>
#include <ROOT/RNTupleModel.hxx>
#include <ROOT/RNTupleUtil.hxx>
#include <ROOT/RNTupleWriteOptions.hxx>
#include <ROOT/RNTupleWriter.hxx>

using ROOT::Experimental::EColumnType;
using ROOT::Experimental::RField;
using ROOT::Experimental::RNTupleModel;
using ROOT::Experimental::RNTupleWriteOptions;
using ROOT::Experimental::RNTupleWriter;

#include <limits>
#include <memory>
#include <string_view>

static constexpr double pi = 3.14159265358979323846;

template <typename T>
static std::shared_ptr<T> MakeFieldReal32Quant(RNTupleModel &model,
std::string_view name,
int nBits, double min, double max) {
assert(nBits >= 1 && nBits <= 32);
assert(max > min);
auto field = std::make_unique<RField<T>>(name);
field->SetQuantized(min, max, nBits);
model.AddField(std::move(field));
return model.GetDefaultEntry().GetPtr<T>(name);
}

void write(std::string_view filename = "types.fundamental.real32quant.root") {
auto model = RNTupleModel::Create();

auto FloatReal32Quant1 =
MakeFieldReal32Quant<float>(*model, "FloatReal32Quant1", 1, -1, 1);
auto FloatReal32Quant8 =
MakeFieldReal32Quant<float>(*model, "FloatReal32Quant8", 8, -1, 1);
auto FloatReal32Quant32 =
MakeFieldReal32Quant<float>(*model, "FloatReal32Quant32", 32, -(float)pi, (float)pi);
auto DoubleReal32Quant1 =
MakeFieldReal32Quant<double>(*model, "DoubleReal32Quant1", 1, -1, 1);
auto DoubleReal32Quant20 =
MakeFieldReal32Quant<double>(*model, "DoubleReal32Quant20", 20, -1, 1);
auto DoubleReal32Quant32 =
MakeFieldReal32Quant<double>(*model, "DoubleReal32Quant32", 32, -100, 25);

RNTupleWriteOptions options;
options.SetCompression(0);
auto writer = RNTupleWriter::Recreate(std::move(model), "ntpl", filename, options);

// First entry: ascending values
*FloatReal32Quant1 = -1.0f;
*FloatReal32Quant8 = -0.5f;
*FloatReal32Quant32 = 0.25f;
*DoubleReal32Quant1 = 0.5;
*DoubleReal32Quant20 = 1.0;
*DoubleReal32Quant32 = 2.0;
writer->Fill();

// Second entry: a value containing all 1s in the mantissa
static constexpr float ValueAllOnes = 2.3509885e-38f;
*FloatReal32Quant1 = ValueAllOnes;
*FloatReal32Quant8 = ValueAllOnes;
*FloatReal32Quant32 = ValueAllOnes;
*DoubleReal32Quant1 = ValueAllOnes;
*DoubleReal32Quant20 = ValueAllOnes;
*DoubleReal32Quant32 = ValueAllOnes;
writer->Fill();

// Third entry: middle values of the value range
*FloatReal32Quant1 = 0;
*FloatReal32Quant8 = 0;
*FloatReal32Quant32 = 0;
*DoubleReal32Quant1 = 0;
*DoubleReal32Quant20 = 0;
*DoubleReal32Quant32 = -37.5;
writer->Fill();

// Fourth entry: min values
*FloatReal32Quant1 = -1;
*FloatReal32Quant8 = -1;
*FloatReal32Quant32 = -pi;
*DoubleReal32Quant1 = -1;
*DoubleReal32Quant20 = -1;
*DoubleReal32Quant32 = -100;
writer->Fill();

// Fifth entry: max values
*FloatReal32Quant1 = 1;
*FloatReal32Quant8 = 1;
*FloatReal32Quant32 = pi;
*DoubleReal32Quant1 = 1;
*DoubleReal32Quant20 = 1;
*DoubleReal32Quant32 = 25;
writer->Fill();
}