[ntuple] don't try to construct an Emulated TClass as a RClassField #17661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
force-pushed
the
ntuple_emu_tfile
branch
from
5a829b0 to
6c10350
Compare
Test Results 18 files 18 suites 4d 9h 48m 43s ⏱️ Results for commit 3fbdd88. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Feb 7, 2025
silverweed
force-pushed
the
ntuple_emu_tfile
branch
2 times, most recently
from
61f2eb1 to
3fbdd88
Compare
When constructing a RClassField we need some information that we don't have when the TClass is Emulated (or less), therefore we now check that we have at least an Interpreted TClass in RFieldBase::Create(). If not, we follow the same logic as when we have no TClass at all (i.e. either create an emulated field or fail, depending on the user options).
silverweed
force-pushed
the
ntuple_emu_tfile
branch
from
3fbdd88 to
55f9b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a RClassField we now require that the TClass is at least Interpreted. If not, we follow the same logic as when we have no TClass at all (i.e. either create an emulated field or fail, depending on the user options).
Checklist:
This PR fixes #17648