[cppyy] fix iadd pythonization for np/array buffers #18999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of wlav/CPyCppyy#51
Fixes #18768
Currently, the
iadd
implementation forstd::vector
inPythonize.cxx
works perfectly with Python lists and iterables for which we have anItemGetter
. But the code path for numpy/array buffers do not. The difference betweenx+=y
andx.__iadd__(y)
leads to unintuitive behaviour: if the intent is to obtain the resulting iterator when calling insert, the user can dod.insert(d.end(), a)
which makes more sense than expecting it fromd+=a
. When the user does calld+=a
, since__iadd__
is overriden, operation does not end with the call toVectorIAdd
which should just return the iterator, and reflect the change by insertion ond
. Instead, it ends withd = d.__iadd__(a)
which reassignsd
to the returned iterator, losing the vector in the process. This PR fixes this by returning self in our pythonization.