-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[core] Disable R__SIZEDDELETE definition for macOS 26 beta #19010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6af1199
to
6f2139c
Compare
6f2139c
to
8b7cea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try just
#ifdef __cpp_sized_deallocation
# define R__SIZEDDELETE
#endif
As far as I understand llvm/llvm-project@ef804d8, libc++ will now also honor the feature flag so my change from commit b5ad658 can be simplified even more.
Test Results 18 files 18 suites 3d 8h 44m 18s ⏱️ Results for commit 7d50deb. ♻️ This comment has been updated with latest results. |
8b7cea8
to
d6ce182
Compare
Thanks Jonas! |
d6ce182
to
7585f6e
Compare
Looks like we need a new reference file for macOS... Though it's curious that the functions are still universally there on Linux, I thought that |
7585f6e
to
5e67744
Compare
5e67744
to
bb42cab
Compare
libc++ now honors the feature flag `__cpp_sized_deallocation` Ref: llvm/llvm-project@ef804d8
bb42cab
to
7d50deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If needed, we can tweak choosing the reference file in the future, for example if some configuration on Linux doesn't enable __cpp_sized_deallocation
either
I'm seeing a local failure of |
MacOS 26.0 beta fails to build without this
This along with #18235 should fix MacOs 26.0 builds
This snippet fails to compile with the latest beta (unless we pass
-fsized-deallocation
):This Pull request:
Changes or fixes:
Checklist:
This PR fixes #