[CMake] Fix compile definitions being passed to rootcling as -D-Dxxx. #19030
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 10h 28m 52s ⏱️ Results for commit fad0d4b. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Jun 13, 2025
Up to version 5.8.4, XRootD exports an extra -D in its compile definitions, which poses a problem when generating the rootcling commands. Until the minimum supported version of XRootD is 5.8.4 or higher, this can be fixed by reading the relevant property and overwriting it with a string without the "-D"s.
hageboeck
force-pushed
the
cmake_cling_compileDefinition
branch
from
f7291ee to
fad0d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing compile definitions to cling, ROOT unconditionally adds -D. Some projects such as XRootD already have -D in their definition, leading to an error such as:
While building module 'NetxNG':
:4:9: error: macro name must be an identifier #define -D_FILE_OFFSET_BITS 64
The "canonical" way in CMake would be to not have explicit
-Ds in the COMPILE_DEFINITIONS property, so we can work around the issue xrootd/xrootd#2543 (fixed in 5.8.4) by overwriting XRootD's COMPILE_DEFINITIONS property.