Skip to content

[ntuple] Remove /bigobj flag for RField.cxx #19337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jul 11, 2025

The file was split some time ago, it should not exceed limits anymore.

The file was split some time ago, it should not exceed limits anymore.
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to check

Copy link

github-actions bot commented Jul 11, 2025

Test Results

    20 files      20 suites   3d 6h 45m 52s ⏱️
 3 198 tests  3 198 ✅ 0 💤 0 ❌
62 357 runs  62 357 ✅ 0 💤 0 ❌

Results for commit bde9cfe.

♻️ This comment has been updated with latest results.

@hahnjo
Copy link
Member Author

hahnjo commented Jul 14, 2025

@bellenot is this ok to merge? The CI seems happy, which matches my expectation. If you need more time to check, that's also fine - the change is not on any critical path for me, just something I noticed while passing by

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just fine, please go ahead!

@hahnjo hahnjo merged commit 34972b8 into root-project:master Jul 14, 2025
64 of 67 checks passed
@hahnjo hahnjo deleted the ntuple-bigobj branch July 14, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants