[ntuple] Correct RValue::GetRef<T> usage or use RValue::GetPtr<void>
#19339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
reviewed
Jul 11, 2025
It was calling the typed RValue::GetRef<std::uint64_t>() which is incorrect because the value actually has type RNTupleCardinality. This worked a bit by chance because the class only has a single member of the right type. Instead of correcting the typed API, which might cause additional checks in the future, use GetPtr<void> and then cast to RNTupleCardinality<std::uint64_t>.
See also the previous commit message for an explanation.
... instead of passing punned types to the templated API.
hahnjo
force-pushed
the
ntuple-RValue-typed
branch
from
c242a88 to
9a8ba50
Compare
Test Results 20 files 20 suites 3d 7h 24m 47s ⏱️ Results for commit 9a8ba50. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for the case-by-case changes and explanations.