Skip to content

[tmva][sofie] Fix bug in getting stride of output of TopK operator #19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

lmoneta
Copy link
Member

@lmoneta lmoneta commented Jul 11, 2025

This PR fixes a bug introduced by mistake in the code used to generate the C++ code for TopK

@lmoneta lmoneta self-assigned this Jul 11, 2025
@lmoneta lmoneta requested a review from sanjibansg July 11, 2025 10:01
Copy link

Test Results

    20 files      20 suites   3d 8h 7m 17s ⏱️
 3 198 tests  3 198 ✅ 0 💤 0 ❌
62 357 runs  62 357 ✅ 0 💤 0 ❌

Results for commit aa5667e.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sanjibansg sanjibansg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@sanjibansg sanjibansg merged commit add1c50 into root-project:master Jul 14, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants